-
Notifications
You must be signed in to change notification settings - Fork 196
Add CVE-2025-0655 Detector #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hey @frkngksl Thanks for the contribution, I've taken a brief look at the plugin but I'm waiting on google/security-testbeds#131 (comment) to do a full evaluation. In the meantime it seems that a newline is missing from Thanks again |
Hi @alessandro-Doyensec , I've already used Google Formatter, but I might miss something of course. Could you please tell me which line is the problem? |
Of course, the last newline (at the end of the file) is missing |
Hi @alessandro-Doyensec , I've added a newline and waiting for your full review. |
...main/java/com/google/tsunami/plugins/detectors/cves/cve20250655/Cve20250655VulnDetector.java
Outdated
Show resolved
Hide resolved
Hey @frkngksl everything is looking good, I just left a comment but nothing big. I was able to verify that the plugin works correctly thanks to the |
Hi @alessandro-Doyensec , Thank you for your review, if it's okay for you, we can discuss your comment under the review comments. |
LGTM - Approved Reviewer: Alessandro, Doyensec |
Hi @tooryx , @maoning ,
This is the plugin PR that resolves #610
Testbed PR for Vulnerable and Fixed Environment: google/security-testbeds#131