Skip to content

Update sharding for activations to include 'dp' axis. Validated on internal notebook, after enabling (2, 1, 4) for (dp, fsdp, tp), do see weights replicated on dp axis. #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update sharding for activations to include 'dp' axis. Validated on internal notebook, after enabling (2, 1, 4) for (dp, fsdp, tp), do see weights replicated on dp axis. #849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tunix/models/gemma/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ class ShardingConfig:
@staticmethod
def get_default_sharding(is_sampling: bool = False):
fsdp = 'fsdp' if not is_sampling else None
b_sharding = tuple(filter(None, ('dp', fsdp)))

return ShardingConfig(
emb_vd=('tp', fsdp),
Expand All @@ -78,9 +79,9 @@ def get_default_sharding(is_sampling: bool = False):
ffw_weight_df=(fsdp, 'tp'),
ffw_weight_fd=('tp', fsdp),
rms_norm_weight=('tp',),
act_btd=('fsdp', None, None if is_sampling else 'tp'),
act_btf=('fsdp', None, 'tp'),
act_btnh=('fsdp', None, 'tp', None),
act_btd=(b_sharding, None, None if is_sampling else 'tp'),
act_btf=(b_sharding, None, 'tp'),
act_btnh=(b_sharding, None, 'tp', None),
score_weight_d1=(fsdp, None),
)

Expand Down
7 changes: 4 additions & 3 deletions tunix/models/gemma3/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ class ShardingConfig:
@staticmethod
def get_default_sharding(is_sampling: bool = False):
fsdp = 'fsdp' if not is_sampling else None
b_sharding = tuple(filter(None, ('dp', fsdp)))

return ShardingConfig(
emb_vd=('tp', fsdp),
Expand All @@ -71,9 +72,9 @@ def get_default_sharding(is_sampling: bool = False):
ffw_weight_df=(fsdp, 'tp'),
ffw_weight_fd=('tp', fsdp),
rms_norm_weight=('tp',),
act_btd=('fsdp', None, None if is_sampling else 'tp'),
act_btf=('fsdp', None, 'tp'),
act_btnh=('fsdp', None, 'tp', None),
act_btd=(b_sharding, None, None if is_sampling else 'tp'),
act_btf=(b_sharding, None, 'tp'),
act_btnh=(b_sharding, None, 'tp', None),
)


Expand Down
7 changes: 4 additions & 3 deletions tunix/models/llama3/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ class ShardingConfig:
@staticmethod
def get_default_sharding(is_sampling: bool = False):
fsdp = 'fsdp' if not is_sampling else None
b_sharding = tuple(filter(None, ('dp', fsdp)))

return ShardingConfig(
emb_vd=('tp', fsdp),
Expand All @@ -72,9 +73,9 @@ def get_default_sharding(is_sampling: bool = False):
ffw_weight_df=(fsdp, 'tp'),
ffw_weight_fd=('tp', fsdp),
rms_norm_weight=('tp',),
act_btd=('fsdp', None, None if is_sampling else 'tp'),
act_btf=('fsdp', None, 'tp'),
act_btnh=('fsdp', None, 'tp', None),
act_btd=(b_sharding, None, None if is_sampling else 'tp'),
act_btf=(b_sharding, None, 'tp'),
act_btnh=(b_sharding, None, 'tp', None),
)


Expand Down
7 changes: 4 additions & 3 deletions tunix/models/qwen2/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ class ShardingConfig:
@staticmethod
def get_default_sharding(is_sampling: bool = False):
fsdp = 'fsdp' if not is_sampling else None
b_sharding = tuple(filter(None, ('dp', fsdp)))

return ShardingConfig(
emb_vd=('tp', fsdp),
Expand All @@ -74,9 +75,9 @@ def get_default_sharding(is_sampling: bool = False):
ffw_weight_df=(fsdp, 'tp'),
ffw_weight_fd=('tp', fsdp),
rms_norm_weight=('tp',),
act_btd=('fsdp', None, None if is_sampling else 'tp'),
act_btf=('fsdp', None, 'tp'),
act_btnh=('fsdp', None, 'tp', None),
act_btd=(b_sharding, None, None if is_sampling else 'tp'),
act_btf=(b_sharding, None, 'tp'),
act_btnh=(b_sharding, None, 'tp', None),
exp_weight_cdf=('fsdp', None, 'tp'),
exp_weight_cfd=('fsdp', 'tp', None),
qkv_bias=('tp',),
Expand Down
7 changes: 4 additions & 3 deletions tunix/models/qwen3/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ class ShardingConfig:
@staticmethod
def get_default_sharding(is_sampling: bool = False):
fsdp = 'fsdp' if not is_sampling else None
b_sharding = tuple(filter(None, ('dp', fsdp)))

return ShardingConfig(
emb_vd=('tp', fsdp),
Expand All @@ -74,9 +75,9 @@ def get_default_sharding(is_sampling: bool = False):
ffw_weight_df=(fsdp, 'tp'),
ffw_weight_fd=('tp', fsdp),
rms_norm_weight=('tp',),
act_btd=('fsdp', None, None if is_sampling else 'tp'),
act_btf=('fsdp', None, 'tp'),
act_btnh=('fsdp', None, 'tp', None),
act_btd=(b_sharding, None, None if is_sampling else 'tp'),
act_btf=(b_sharding, None, 'tp'),
act_btnh=(b_sharding, None, 'tp', None),
exp_weight_cdf=('fsdp', None, 'tp'),
exp_weight_cfd=('fsdp', 'tp', None),
)
Expand Down
Loading