Skip to content

Fix AttributeError in is_positive_integer on Python 3.11 #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bug39 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix AttributeError in is_positive_integer on Python 3.11 #903

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e77c78e
Fix AttributeError in is_positive_integer()
bug39 Dec 17, 2025
d8749ed
Update utils.py with is_integer_value
bug39 Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tunix/rl/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,15 @@
Mesh = jax.sharding.Mesh
NamedSharding = jax.sharding.NamedSharding


def is_positive_integer(value: int | None, name: str):
"""Checks if the value is positive."""
if value is not None and (not value.is_integer() or value <= 0):
def is_positive_integer(value: int | float | None, name: str) -> None:
"""Checks if the value is a positive integer."""
if value is not None and (not is_integer_value(value) or value <= 0):
raise ValueError(f"{name} must be a positive integer. Got: {value}")

def is_integer_value(value) -> bool:
"""Checks if the value is an integer"""
return (isinstance(value, int) and not isinstance(value, bool)) or (isinstance(value, float) and value.is_integer())


def check_divisibility(
small_size,
Expand Down