Skip to content

Override toString for All Private Classes #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2024
Merged

Override toString for All Private Classes #110

merged 2 commits into from
May 27, 2024

Conversation

HamdaanAliQuatil
Copy link
Collaborator

@HamdaanAliQuatil HamdaanAliQuatil commented May 7, 2024 •
edited
Loading

Closes #104

Updated the following Private Functions:

  • _HmacSecretKey
  • _AesCbcSecretKey
  • _AesCtrSecretKey
  • _AesGcmSecretKey
  • _EcdhPublicKey/ PrivateKey
  • _EcdsaPublicKey/ PrivateKey
  • _HkdfSecretKey
  • _Pbkdf2SecretKey
  • _RsaOaepPublicKey
  • _RsaPssPublicKey
  • _RsassaPkcs1V15PublicKey

No issues found in:

  • _Hash

@jonasfj jonasfj self-requested a review May 8, 2024 10:11
@jonasfj
Copy link
Member

jonasfj commented May 8, 2024

I think we should add the same thing to all private classes throughout the package.

Like RsaOaepPublicKey, etc. they also have private implementations.

@HamdaanAliQuatil HamdaanAliQuatil changed the title feat: override toString for _HmacSecretKey feat: override toString for All Private Methods May 15, 2024
@HamdaanAliQuatil HamdaanAliQuatil marked this pull request as draft May 15, 2024 18:32
@HamdaanAliQuatil HamdaanAliQuatil changed the title feat: override toString for All Private Methods Override toString for All Private Classes May 21, 2024
@HamdaanAliQuatil HamdaanAliQuatil marked this pull request as ready for review May 24, 2024 13:26
jonasfj
jonasfj approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@jonasfj jonasfj merged commit b3518ba into google:master May 27, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasfj jonasfj jonasfj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add .toString() methods on all private classes
2 participants
@HamdaanAliQuatil @jonasfj