Replace KeyPair class with record typedef KeyPair<T,S>
#195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This is technically breaking right, but not very breaking. I was contemplating if we should group with other breaking changes. But maybe we should just decide that it's not that breaking. |
jonasfj
reviewed
Mar 7, 2025
Member
jonasfj
left a comment
jonasfj
left a comment
There was a problem hiding this comment.
Let's update the CHANGELOG.md so that we have entry for this change, ready for the next release.
This is technically breaking, but probably so little breaking that it won't affect anyone.
Collaborator
Author
Created a PR to update |
jonasfj
approved these changes
May 2, 2025
lib/src/testing/webcrypto/ecdh.dart
Outdated
|
|
||
| _KeyPair({required this.privateKey, required this.publicKey}); | ||
| } | ||
| typedef KeyPair<S, T> = ({S privateKey, T publicKey}); |
|
|
||
| _KeyPair({required this.privateKey, required this.publicKey}); | ||
| } | ||
| typedef KeyPair<S, T> = ({S privateKey, T publicKey}); |
Merged
jonasfj
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #191