Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
1b6dd60 to
6dff751
Compare
00caa98 to
532cd9f
Compare
----
Implement External Nodes for Groups
This commit introduces the concept of external nodes to Groups.
It allows a node in the parent graph to be connected to a node
in a group without having to include the external node in the group itself.
The main changes are:
- External Target: The External target provides a `Map<string, { nodes: string[], point: Point, type: 'in'|'out' }>` for each Group
- `internalEdges` input in the Graph: This array is used to provide the edges that are connecting the Group with external nodes
- Rendering logic: The external target node is rendered with a default proxy node template.
- Rendering logic: The edges between the external nodes and internal nodes are rendered.
This feature enable the following:
- Connect a Node in the main DAG to a Node in a Group without having to declare the node in the Group
- Connect a Group with external Nodes
- Keep a consistent look for the group.
- Create complex diagrams using subgraphs.
Limitations
- If two nodes are in different groups or have a parental difference of more than 1 then we can't show edges between them yet.
- This feature currently works in layout direction left to right or right to left, while using layout top to bottom or bottom to top there is some shifting in x axis of the node
PiperOrigin-RevId: 777884537
532cd9f to
5e17532
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Addition
Implement External Nodes for Groups
This commit introduces the concept of external nodes to Groups.
It allows a node in the parent graph to be connected to a node
in a group without having to include the external node in the group itself.
The main changes are:
Map<string, { nodes: string[], point: Point, type: 'in'|'out' }>for each GroupinternalEdgesinput in the Graph: This array is used to provide the edges that are connecting the Group with external nodesThis feature enable the following:
Limitations