Relax dependency requirements to allow use with Rack 3 #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to upgrade to `rack` 3.x in our project. To do this we need to upgrade to `wasabi` to 5.x and `httpi` to 4.x, but this is prevented by the dependency requirements of `google-ads-common` and `google-ads-savon`. According to the changelog, these versions are restricted to "tighten dependency requirements to maintain 2.7 support", but this makes no sense. A project is of course free to use older versions of these dependencies compatible with Ruby 2.7, but it should not be a requirement to use outdated gems if you are using a newer version of Ruby. The newer versions of `akamai`, `faraday`, `faraday-net_http`, `httpi`, `nokogiri`, `nori`, `public_suffix`, `rack`, `rake`, and `wasabi` all seem to be compatible with the current implementation of `google-ads-common` and `google-ads-savon`.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to upgrade
rackto 3.x in our project. To do this we need to upgradewasabito 5.x andhttpito 4.x, but this is prevented by the dependency requirements ofgoogle-ads-commonandgoogle-ads-savon.According to the changelog, these versions are restricted to "tighten dependency requirements to maintain 2.7 support", but this makes no sense. A project is of course free to use older versions of these dependencies compatible with Ruby 2.7, but it should not be a requirement to use outdated gems if you are using a newer version of Ruby.
The newer versions of
akamai,faraday,faraday-net_http,httpi,nokogiri,nori,public_suffix,rack,rake, andwasabiall seem to be compatible with the current implementation ofgoogle-ads-commonandgoogle-ads-savon.