Moloco Native Ad: Add support for native ads for the Moloco SDK #549
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
yamir-godil
force-pushed
the
moloco_native_ads_support
branch
from
df7bb1d to
0634a9f
Compare
yamir-godil
force-pushed
the
moloco_native_ads_support
branch
from
0634a9f to
430a4a9
Compare
| MediationAdLoadCallback<UnifiedNativeAdMapper, MediationNativeAdCallback>, | ||
| // TODO: Add other parameters or remove unnecessary ones. | ||
| ) : UnifiedNativeAdMapper() { | ||
| MediationAdLoadCallback<UnifiedNativeAdMapper, MediationNativeAdCallback>, |
There was a problem hiding this comment.
We are trying to replace UnifiedNativeAdMapper with NativeAdMapper, could you please update to that class instead? https://developers.google.com/android/reference/com/google/android/gms/ads/mediation/NativeAdMapper
| } | ||
|
|
||
| companion object { | ||
| fun newInstance( | ||
| mediationNativeAdConfiguration: MediationNativeAdConfiguration, | ||
| mediationNativeAdLoadCallback: | ||
| MediationAdLoadCallback<UnifiedNativeAdMapper, MediationNativeAdCallback>, | ||
| MediationAdLoadCallback<UnifiedNativeAdMapper, MediationNativeAdCallback>, | ||
| ): Result<MolocoNativeAd> { | ||
| val context = mediationNativeAdConfiguration.context |
There was a problem hiding this comment.
I don't think I see the context being used anywhere, so it is safe to delete.
|
|
||
| /** | ||
| * Used to load Moloco native ads and mediate callbacks between Google Mobile Ads SDK and Moloco | ||
| * SDK. | ||
| */ | ||
| class MolocoNativeAd | ||
| private constructor( | ||
| private val context: Context, | ||
| private val adUnitId: String, | ||
| private val nativeAdOptions: NativeAdOptions, // TODO: Not sure where to use this? |
There was a problem hiding this comment.
You can take a look at what options are in this class and map them to any configuration that can be added to Moloco's NativeAds https://developers.google.com/admob/android/native/options. I dare say, video options is one of common interest for many ad networks.
| private val drawable: Drawable, | ||
| private val uri: Uri = Uri.EMPTY, | ||
| private val scale: Double = 1.0, | ||
| ) : com.google.android.gms.ads.formats.NativeAd.Image() { // Google deprecated the class, but didn't offer an alternative. So for now we *must* use the deprecated class. |
There was a problem hiding this comment.
Once the UnifiedNativeAdMapper is updated to NativeAdMapper, the non-deprecated class can be used: https://developers.google.com/android/reference/com/google/android/gms/ads/nativead/NativeAd.Image
Summary
NOTE: Please do the E2E verification before merging this change in. I had trouble establishing the build dependencies and prepared the adapter from our internal source without being able to compile the google project.
Testing
Added unit tests and all tests pass
