fix: drop packaging and pkg_resources #2477
Conversation
product-auto-label
bot
added
size: xl
|
|
||
| ParsedVersion = Tuple[int, ...] | ||
|
|
||
| def parse_version_to_tuple(version_string: str) -> ParsedVersion: # pragma: NO COVER |
There was a problem hiding this comment.
This is duplicated from https://github.com/googleapis/python-api-core/blob/main/google/api_core/_python_package_support.py. At the very least, add a TODO to remove this once the GAPICs can depend on an appropriate version of api_core, but ideally you can include this in a conditional to define this only if this symbol does not exist in the imported api_core.
There was a problem hiding this comment.
Hmm good point, but I noticed it's not technically a public method in api_core. So I'm not sure if we really should be referencing it in here if we have to grab it from the internal google.api_core._python_package_support module. In hindsight, this probably should have been exported in the __init__ with the others.
But I also notice that this block of code could be moved within this conditional, which is already commented in the way you describe. Would that be sufficient?
There was a problem hiding this comment.
@daniel-sanche Your suggestion sounds good to me. Good catch!
There was a problem hiding this comment.
Yes, putting it in the conditional is what I had in mind.
And you're right that we should export the symbol in the __init__. I'll do that.
There was a problem hiding this comment.
There was a problem hiding this comment.
Ok, I made the change, let me know if that works
Similar to googleapis/python-api-core#852
Fixes #2475