Skip to content

impl(bigtable): conf test fail on incomplete data #15776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scotthart merged 1 commit into from
Nov 18, 2025
Merged

impl(bigtable): conf test fail on incomplete data #15776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions google/cloud/bigtable/ci/run_conformance_tests_proxy_bazel.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ exit_status=$?
# CloseClient
go test -v \
-run "TestExecuteQuery|TestExecuteQuery_PlanRefresh$|TestExecuteQuery_PlanRefresh_WithMetadataChange|TestExecuteQuery_PlanRefresh_Retries|TestExecuteQuery_FailsOnSuccesfulStreamWithNoToken" \
-skip "CloseClient|FailsOnEmptyMetadata|FailsOnExecuteQueryMetadata|FailsOnInvalidType|FailsOnNotEnoughData|FailsOnNotEnoughDataWithCompleteRows|FailsOnSuccesfulStreamWithNoToken|ChecksumMismatch|FailsOnTypeMismatch|FailsOnTypeMismatchWithinMap|FailsOnTypeMismatchWithinArray|FailsOnTypeMismatchWithinStruct|FailsOnStructMissingField|TestExecuteQuery_PlanRefresh_AfterResumeTokenCausesError|TestExecuteQuery_RetryTest_WithPlanRefresh|TestExecuteQuery_PlanRefresh_RespectsDeadline|TestExecuteQuery_PlanRefresh_RecoversAfterPermanentError" \
-skip "CloseClient|FailsOnEmptyMetadata|FailsOnExecuteQueryMetadata|FailsOnInvalidType|ChecksumMismatch|FailsOnTypeMismatch|FailsOnTypeMismatchWithinMap|FailsOnTypeMismatchWithinArray|FailsOnTypeMismatchWithinStruct|FailsOnStructMissingField|TestExecuteQuery_PlanRefresh_AfterResumeTokenCausesError|TestExecuteQuery_RetryTest_WithPlanRefresh|TestExecuteQuery_PlanRefresh_RespectsDeadline|TestExecuteQuery_PlanRefresh_RecoversAfterPermanentError" \
-proxy_addr=:9999
exit_status=$?

Expand All @@ -67,7 +67,7 @@ exit_status=$?

# Stream reading tests b/461232110
#go test -v \
# -run "FailsOnNotEnoughData|FailsOnNotEnoughDataWithCompleteRows|ChecksumMismatch" \
# -run "ChecksumMismatch" \
# -proxy_addr=:9999
#exit_status=$?

Expand All @@ -79,7 +79,7 @@ exit_status=$?

# QueryPlan refresh tests b/461233613
#go test -v \
# -run "RetryTest_WithPlanRefresh|PlanRefresh" \
# -run "RetryTest_WithPlanRefresh|PlanRefresh|PlanRefresh_RecoversAfterPermanentError" \
# -proxy_addr=:9999
#exit_status=$?

Expand Down
3 changes: 2 additions & 1 deletion google/cloud/bigtable/internal/partial_result_set_source.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,10 @@ Status PartialResultSetSource::BufferProtoRows() {
GCP_ERROR_INFO());
}
if (proto_values.size() % columns_size != 0) {
state_ = State::kFinished;
return internal::InternalError(
"The number of values in ProtoRows is not a multiple of the "
"number of columns in the schema.",
"number of columns in the schema or received incomplete row",
GCP_ERROR_INFO());
}

Expand Down