feat: Add mTLS support with client certificates #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for mutual TLS (mTLS) authentication using client certificates configured via environment variables. Changes: - Add GOOGLE_CLIENT_CERT/GEMINI_CLIENT_CERT and GOOGLE_CLIENT_KEY/GEMINI_CLIENT_KEY environment variables for configuring client certificates - Extend ApiClient to use Undici agent with mTLS configuration - Add dispatcher field to HttpOptions interface for custom HTTP agent - Fix patchHttpOptions to preserve non-serializable fields like dispatcher - Move undici from devDependencies to dependencies - Add mTLS documentation section to README The implementation automatically creates an Undici agent when both client certificate and key are provided, enabling mTLS for all HTTP requests in Node.js environments.
feat: Add mTLS support with client certificates
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
Hi @pepeiborra , Can you please resolve the conflict by signing the CLA? Thank You!! |
shmishra99
added
api:gemini-api
type: feature request
Author
|
Signed |
shmishra99
removed
the
status:awaiting user response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for mutual TLS (mTLS) authentication using client certificates
configured via environment variables.
Changes:
environment variables for configuring client certificates