fix: uploadFileToFileSearchStore missing displayName #1208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Blob uploads are missing document names. As a result, when querying the FileSearchStore via the Gemini tool,
GroundingMetadatadoesn't include the document name, since it doesn't exist -- which means citations can't back reference the document they originated from.Reason
uploadFileToFileSearchStoreaccepts adisplayNameperUploadToFileSearchStoreConfigjs-genai/src/types.ts
Lines 4989 to 4990 in 8683694
However, it is ignored, and instead the file name is determined by
getFileName(file), basing the name off of the file pathjs-genai/src/_api_client.ts
Lines 673 to 680 in 8683694
Furthermore, when providing a
Blobas the file, there is no file path, so the document is left unnamed, even ifdisplayNameis provided.Solution
When
config.displayNameis provided, use that. Otherwise, fallback to existing behavior viagetFileName(name)Reproducible Steps
Blobto a FileSearchStoredisplayName