Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #712
This pull request updates how the
undiciHTTP client library is managed and integrated in the project, moving it from a direct dependency to a peer dependency, and adds improved Node.js HTTP timeout handling usingundici'sAgent. It also introduces corresponding test coverage for this new behavior.Dependency management:
undiciandundici-typestopeerDependenciesinpackage.json, and marked them as optional inpeerDependenciesMeta. This makes them optional peer dependencies instead of always-installed direct dependencies.Node.js HTTP request improvements:
src/_api_client.ts, updated the request logic to dynamically importundiciand set a customAgentwith timeout options for Node.js environments, improving HTTP timeout handling.Testing:
test/unit/api_client_test.tsto verify that thedispatcherwith timeouts is set on HTTP requests in Node.js, and imported the requiredAgentand types fromundicifor testing.Shout out to @yulisunny for spotting the issue, I tested this on vercel it's working!