Skip to content

chore: adhere to PEP 585 and removed unused imports #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vishwarajanand merged 4 commits into from
Dec 10, 2024
Merged

chore: adhere to PEP 585 and removed unused imports #283

vishwarajanand merged 4 commits into from
Dec 10, 2024

Conversation

@vishwarajanand
Copy link
Contributor

@vishwarajanand vishwarajanand commented Dec 7, 2024 •
edited
Loading

As of Python 3.9 and PEP 585 we can use standard collections like
list, dict, tuple for typing instead of the now deprecated

from typing import Dict, List, Tuple ...

Also removing a ton of unused imports.

Note:

Pinned pydantic package version to 2.9.0 to avoid a reasoning engine failure.

@product-auto-label product-auto-label bot added the api: alloydb Issues related to the googleapis/langchain-google-alloydb-pg-python API. label Dec 7, 2024
@vishwarajanand vishwarajanand marked this pull request as ready for review December 7, 2024 14:29
@vishwarajanand vishwarajanand requested review from a team as code owners December 7, 2024 14:29
jackwotherspoon
jackwotherspoon requested changes Dec 7, 2024
View reviewed changes
@vishwarajanand vishwarajanand mentioned this pull request Dec 9, 2024
Merged
@vishwarajanand vishwarajanand merged commit 779f18a into main Dec 10, 2024
12 checks passed
@vishwarajanand vishwarajanand deleted the pep585-compliance branch December 10, 2024 15:23
Feromar98 added a commit to Feromar98/langchain-google-alloydb-pg-python that referenced this pull request Mar 12, 2025
@Feromar98 @vishwarajanand
@twishabansal @averikitsch @dishaprakash @kurtisvg @release-please @dependabot
Langgraph base (#1)
d9fbd5d 
* chore: pin pydantic version to avoid a reasoning engine failure (googleapis#284)

* chore: adhere to PEP 585 and removed unused imports (googleapis#283)

* chore: Migration guide update (googleapis#286)

* Separate alloydb prep steps

* mention default public ip

* chore(docs): add context to vector store migration (googleapis#288)

* chore(docs): Add multiple namespaces option in migration guide. (googleapis#290)

* fix: Add multiple namespaces option in migration guide.

* Changed layout

* Changed layout

* Minor fix

* Minor fix

* Minor fix

---------

Co-authored-by: Averi Kitsch <[email protected]>

* fix: update MEM version comparison (googleapis#291)

* fix: update MEM version comparison

* lint

* debug

* remove change

* convert name

* lint

* docs: update docs to convert sync to async (googleapis#287)

* docs: update docs to convert sync to async

* format

* format

* format

* format

* convert copy/paste to sync

* restore

* update migration

* feat: add engine_args argument to engine creation functions (googleapis#293)

* feat: add engine_args argument to engine creation functions

* chore: fix formatting issues

* chore: add space for multi-line formatting

* chore: add basic tests

* chore: fix reference to pool size

* chore: diff syntax

* chore: diff syntax

* chore: real syntax this time

* Update tests/test_engine.py

---------

Co-authored-by: Averi Kitsch <[email protected]>

* chore(ci): Update python version for docs pipeline (googleapis#294)

* chore(main): release 0.9.0 (googleapis#268)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Averi Kitsch <[email protected]>

* chore(deps): bump jinja2 from 3.1.4 to 3.1.5 in /.kokoro (googleapis#308)

Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](pallets/jinja@3.1.4...3.1.5)

---
updated-dependencies:
- dependency-name: jinja2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat(checkpointer): create checkpoint engine methods + tests (googleapis#309)

* feat(checkpointer): create checkpoint engine methods + tests

* fix(checkpointer): address comments

* fix(checkpointer): Fix test errors

* clean up

* drop tables

---------

Co-authored-by: Averi Kitsch <[email protected]>

* feat(langgraph-base): create checkpoint aput method + tests (googleapis#321)

* feat(langgraph-base): create checkpoint aput method + tests

* fix(langgraph-base): add test case, add dependencies

* lint

* fix(langgraph-base-aput): address comments

* lint

---------

Co-authored-by: Averi Kitsch <[email protected]>

* feat(langgraph-base): create async put_writes method + tests (googleapis#323)

* feat(langgraph-base): create checkpoint aput method + tests

* fix(langgraph-base): add test case, add dependencies

* fix(langgraph-base-aput_writes): add missing code

* fix(langgraph-base-aput_writes): create a new aput_writes test and address comment

* fix(langgraph-base): add configurable table_name and fix some format issues

* update table names

* fix test

---------

Co-authored-by: Averi Kitsch <[email protected]>

* feat(Langgraph-base-alist): create async list method + tests (googleapis#324)

* feat(langgraph-base): create checkpoint aput method + tests

* fix(langgraph-base): add test case, add dependencies

* feat(langgraph-base-alist): add async list method + tests

* fix(langgraph-base): run lints black and isort

* fix(langgraph-base): address comments

* feat(langgraph-base): create async get_tuple method + tests (googleapis#325)

* feat(langgraph-base): create checkpoint aput method + tests

* fix(langgraph-base): add test case, add dependencies

* feat(langgraph-base-alist): add async list method + tests

* fix(langgraph-base): run lints black and isort

* fix(langgraph-base): address comments

* fix(langgraph-base): fixed integration tests errors

* feat(langgraph-base): created aget_tuple method + tests

* fix(langgraph-base): fix lints

* fix(langgraph-base): address comments and fixed test cases

* fix(langgraph-base): run linters black and isort

* fix(langgraph-base): address comments

* fix(langgraph-base): add langgraph as a requirement for the tests

* update the implementation

* fix

---------

Co-authored-by: Averi Kitsch <[email protected]>

* feat(langgraph-base-sync): checkpoint class (googleapis#349)

* feat(langgraph-base): create checkpoint aput method + tests

* fix(langgraph-base): add test case, add dependencies

* feat(langgraph-base-alist): add async list method + tests

* fix(langgraph-base): run lints black and isort

* fix(langgraph-base): address comments

* fix(langgraph-base): fixed integration tests errors

* feat(langgraph-base): created aget_tuple method + tests

* feat(langgraph-base): create sync checkpointer methods into async_checkpoint file

* feat(langgraph-base): create sync checkpoint class

* feat(langgraph-base): add test cases

* fix(langgraph-base): fix lints

* fix(langgraph-base): address comments and fixed test cases

* fix(langgraph-base): run linters black and isort

* fix(langgraph-base): address comments

* fix(langgraph-base): add langgraph as a requirement for the tests

* Update async_checkpoint.py

* Update test_async_checkpoint.py

* Update async_checkpoint.py

* fix(langgraph-base): address comments fo fixing test errors

* feat(langgraph-base): add more tests for checkpoint

* Revert "Merge branch 'langgraph-base-aget-tuple' into langgraph-base-sync"

This reverts commit 5c1ccb8, reversing
changes made to a8224f4.

* fix(langgraph-base-sync): fixed tests for async and sync checkpoint

* fix(langgraph-base-sync): deleted unnecessary lines

* fix: follow CLA and conventionacommits

* Update tests/test_checkpoint.py

---------

Co-authored-by: Averi Kitsch <[email protected]>
Co-authored-by: Fernando Omar Salazar Ortiz <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Vishwaraj Anand <[email protected]>
Co-authored-by: Twisha Bansal <[email protected]>
Co-authored-by: Averi Kitsch <[email protected]>
Co-authored-by: dishaprakash <[email protected]>
Co-authored-by: Kurtis Van Gent <[email protected]>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Fernando Omar Salazar Ortiz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@averikitsch averikitsch averikitsch approved these changes

@jackwotherspoon jackwotherspoon jackwotherspoon approved these changes

Assignees

@anubhav756 anubhav756

Labels

api: alloydb Issues related to the googleapis/langchain-google-alloydb-pg-python API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vishwarajanand @averikitsch @jackwotherspoon @anubhav756