Skip to content

chore(docs): Highlight how to use Private IP in Engine class. #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
averikitsch merged 4 commits into from
Feb 20, 2025
Merged

chore(docs): Highlight how to use Private IP in Engine class. #270

averikitsch merged 4 commits into from
Feb 20, 2025

Conversation

@dishaprakash
Copy link
Contributor

@dishaprakash dishaprakash commented Feb 19, 2025

chore(docs): Highlight how to use Private IP in Engine class.

@dishaprakash dishaprakash requested review from a team as code owners February 19, 2025 08:48
@product-auto-label product-auto-label bot added the api: cloudsql-postgres Issues related to the googleapis/langchain-google-cloud-sql-pg-python API. label Feb 19, 2025
jackwotherspoon
jackwotherspoon requested changes Feb 19, 2025
View reviewed changes
@dishaprakash dishaprakash marked this pull request as draft February 20, 2025 08:40
@dishaprakash
Copy link
Contributor Author

dishaprakash commented Feb 20, 2025

The lint test was failing and on running black . the bigger changes went through on both the quickstart and chat history notebooks.

@dishaprakash dishaprakash marked this pull request as ready for review February 20, 2025 08:44
jackwotherspoon
jackwotherspoon approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@averikitsch averikitsch merged commit 6fcbe51 into main Feb 20, 2025
11 checks passed
@averikitsch averikitsch deleted the private-ip branch February 20, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@averikitsch averikitsch averikitsch approved these changes

@jackwotherspoon jackwotherspoon jackwotherspoon approved these changes

Assignees

@anubhav756 anubhav756

Labels

api: cloudsql-postgres Issues related to the googleapis/langchain-google-cloud-sql-pg-python API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dishaprakash @averikitsch @jackwotherspoon @anubhav756