refactor: parse embedding dimensions as float[] for numpyV2 #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: cloudsql-postgres
Closed
averikitsch
approved these changes
Mar 3, 2025
Collaborator
averikitsch
left a comment
averikitsch
left a comment
There was a problem hiding this comment.
Can you update the commit message to use "refactor:"?
Thank you @vishwarajanand !
vishwarajanand
changed the title
dishaprakash
pushed a commit
that referenced
this pull request
Mar 17, 2025
dishaprakash
pushed a commit
that referenced
this pull request
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per this comment, separating out the code changes for numpy #V2.
This change is needed because when using numpy V2, if a numpy array is converted to string then it comes as numpy objects rather than float array. ref
Changes include: