Skip to content

chore: Fix LoopConnectorError by enforcing background loop execution for Async Classes tests #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
averikitsch merged 10 commits into from
Dec 2, 2025
Merged

chore: Fix LoopConnectorError by enforcing background loop execution for Async Classes tests #377

averikitsch merged 10 commits into from
Dec 2, 2025

Conversation

@dishaprakash
Copy link
Contributor

@dishaprakash dishaprakash commented Dec 2, 2025 •
edited
Loading

This PR:

  • Adds a run_on_background helper to test fixtures.
  • Wraps direct calls to _ainit methods in PostgresEngine and AsyncVectorStore operations in tests to ensure they execute on the engine's background loop, matching the new strict loop enforcement.

@product-auto-label product-auto-label bot added the api: cloudsql-postgres Issues related to the googleapis/langchain-google-cloud-sql-pg-python API. label Dec 2, 2025
@dishaprakash dishaprakash changed the title chore: Update tests for Async Classes chore: Fix LoopConnectorError by enforcing background loop execution for Async Classes tests Dec 2, 2025
@dishaprakash dishaprakash marked this pull request as ready for review December 2, 2025 08:19
@dishaprakash dishaprakash requested review from a team as code owners December 2, 2025 08:19
@averikitsch averikitsch merged commit b3d8d82 into main Dec 2, 2025
12 checks passed
@averikitsch averikitsch deleted the fix-connector-loop branch December 2, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@averikitsch averikitsch averikitsch approved these changes

Assignees

@averikitsch averikitsch

Labels

api: cloudsql-postgres Issues related to the googleapis/langchain-google-cloud-sql-pg-python API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dishaprakash @averikitsch @anubhav756