chore: use cobra flag group for config flags#3477
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ConfigFileFlags function to accept the parent Cobra command and enforces mutual exclusivity among the configuration flags (config, configs, and config-folder). The reviewer suggests extending this mutual exclusivity validation to also include the deprecated alias flags (tools-file, tools-files, and tools-folder) to prevent users from bypassing the validation when mixing deprecated and new flags.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
duwenxin99
approved these changes
Jun 23, 2026
8d30576 to
0b26200
Compare
Contributor
|
🧨 Preview deployments removed. Cloudflare Pages environments for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use cobra flag groups (
MarkFlagsMutuallyExclusive) for the config flags.The following error occurs during startup when both
--configand--configswere set.🛠️ Fixes #782