Skip to content

feat: Add dataplex-get-data-asset tool#3503

Open
theantagonist9509 wants to merge 45 commits into
googleapis:mainfrom
theantagonist9509:feat/dataplex-get-data-asset
Open

feat: Add dataplex-get-data-asset tool#3503
theantagonist9509 wants to merge 45 commits into
googleapis:mainfrom
theantagonist9509:feat/dataplex-get-data-asset

Conversation

@theantagonist9509

@theantagonist9509 theantagonist9509 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Important

Stacked Changeset: This PR depends on changes in previous PRs (#3337, #3499, #3500).

  • Please merge previous PRs first before reviewing/merging this one.
  • The file diff below will appear large as it includes its ancestors' commits. It will resolve itself once the preceding PRs are merged and this branch is synced.

This PR implements the dataplex-get-data-asset tool for the Dataplex
(Knowledge Catalog) source, allowing users to fetch detailed configuration
metadata for a single Data Asset.

Changes overview:

  • Dataplex Source: Implemented GetDataAsset to retrieve details for a
    specific asset by location, data product, and asset ID. The response maps the
    resource URI, labels, and access group configurations.
  • New Tool: Created the dataplex-get-data-asset tool exposing locationId ,
    dataProductId , and dataAssetId parameters.
  • Tests:
    • Added unit tests for tool configuration parsing.
    • Added integration tests asserting successful metadata retrieval and
      authorization checks.
  • Documentation: Created the reference page for the tool, updated the
    Dataplex source guide, and added it to the main capabilities list.

theantagonist9509 and others added 30 commits June 2, 2026 14:15

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Dataplex Data Products and Data Assets by introducing four new tools: dataplex-list-data-products, dataplex-get-data-product, dataplex-list-data-assets, and dataplex-get-data-asset. It includes the necessary client initializations, source methods, unit and integration tests, prebuilt configurations, and documentation. A critical issue was found in internal/sources/dataplex/dataplex.go where the error check for GetOperation was accidentally removed, which could lead to a nil pointer panic during protojson marshalling if the operation retrieval fails.

Comment thread internal/sources/dataplex/dataplex.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants