feat: Add dataplex-get-data-asset tool#3503
Open
theantagonist9509 wants to merge 45 commits into
Open
Conversation
…data-products mapping fix
…ke teardowns concurrent
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for Dataplex Data Products and Data Assets by introducing four new tools: dataplex-list-data-products, dataplex-get-data-product, dataplex-list-data-assets, and dataplex-get-data-asset. It includes the necessary client initializations, source methods, unit and integration tests, prebuilt configurations, and documentation. A critical issue was found in internal/sources/dataplex/dataplex.go where the error check for GetOperation was accidentally removed, which could lead to a nil pointer panic during protojson marshalling if the operation retrieval fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Stacked Changeset: This PR depends on changes in previous PRs (#3337, #3499, #3500).
This PR implements the dataplex-get-data-asset tool for the Dataplex
(Knowledge Catalog) source, allowing users to fetch detailed configuration
metadata for a single Data Asset.
Changes overview:
specific asset by location, data product, and asset ID. The response maps the
resource URI, labels, and access group configurations.
dataProductId , and dataAssetId parameters.
authorization checks.
Dataplex source guide, and added it to the main capabilities list.