feat(looker): support dynamic_fields parameter in queries#3507
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for an optional dynamic_fields parameter across Looker query tools (looker-query, looker-query-sql, and looker-query-url). The parameter allows users to define ad-hoc calculations like table calculations, custom measures, and custom dimensions. The changes span documentation, prebuilt configurations, Go implementation in lookercommon.go, and corresponding unit and integration tests. Feedback suggests adding a defensive check to ensure the dynamic_fields slice contains elements before marshaling it to JSON, preventing empty arrays from being sent to the Looker API.
drstrangelooker
force-pushed
the
looker-query-dynamic-fields
branch
9 times, most recently
from
1f8d020 to
b7a176b
Compare
drstrangelooker
force-pushed
the
looker-query-dynamic-fields
branch
from
75e0bd9 to
1f8d020
Compare
drstrangelooker
force-pushed
the
looker-query-dynamic-fields
branch
from
b7a176b to
df08356
Compare
drstrangelooker
added
the
release candidate
duwenxin99
approved these changes
Jun 25, 2026
Contributor
|
🧨 Preview deployments removed. Cloudflare Pages environments for |
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 25, 2026
) ## Description Support a dynamic_fields parameter to a query. This allows custom table calcs to be added to queries. ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/mcp-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/mcp-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 🛠️ Fixes #3456 cd22b89
github-actions Bot
pushed a commit
to huangjiahua/genai-toolbox
that referenced
this pull request
Jun 25, 2026
…ogleapis#3507) ## Description Support a dynamic_fields parameter to a query. This allows custom table calcs to be added to queries. ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/mcp-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/mcp-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 🛠️ Fixes googleapis#3456 cd22b89
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support a dynamic_fields parameter to a query. This allows custom table calcs to be added to queries.
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
!if this involve a breaking change🛠️ Fixes #3456