Skip to content

fix(tool/looker-create-view-from-table): correct Looker API payload s…#3515

Merged
drstrangelooker merged 3 commits into
googleapis:mainfrom
dhruvingandhi:fix/looker-create-view-from-table-payload
Jun 25, 2026
Merged

fix(tool/looker-create-view-from-table): correct Looker API payload s…#3515
drstrangelooker merged 3 commits into
googleapis:mainfrom
dhruvingandhi:fix/looker-create-view-from-table-payload

Conversation

@dhruvingandhi

@dhruvingandhi dhruvingandhi commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes an issue where the looker-create-view-from-table tool triggers a 500 Internal Server Error from the Looker API. The API expects a JSON object wrapper with a tables property containing the array of tables, but the code was passing the raw array directly.

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

  • Make sure you reviewed
    CONTRIBUTING.md
  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Make sure to add ! if this involve a breaking change

🛠️ Fixes #3514

@dhruvingandhi dhruvingandhi requested review from a team as code owners June 24, 2026 18:45
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 24, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CreateViewsFromTables function in internal/tools/looker/lookercommon/lookercommon.go to pass the entire reqBody struct instead of just the reqBody.Tables slice, ensuring the API receives a JSON object with a tables property rather than a raw array. There are no review comments, and I have no additional feedback to provide.

@drstrangelooker

drstrangelooker commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

/gcbrun

@drstrangelooker drstrangelooker added the tests: run Label to trigger Github Action tests. label Jun 24, 2026
@github-actions github-actions Bot removed the tests: run Label to trigger Github Action tests. label Jun 24, 2026
@drstrangelooker

drstrangelooker commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

/gcbrun

@drstrangelooker drstrangelooker enabled auto-merge (squash) June 25, 2026 17:21
@drstrangelooker drstrangelooker merged commit 18c539c into googleapis:main Jun 25, 2026
20 checks passed
@release-please release-please Bot mentioned this pull request Jun 25, 2026
Merged
Yuan325 added a commit that referenced this pull request Jul 1, 2026
@release-please @Yuan325
chore(main): release 1.6.0 (#3495)
35c13ad 
🤖 I have created a release *beep* *boop*
---


##
[1.6.0](v1.5.0...v1.6.0)
(2026-06-30)


### Features

* Support MCP 2026 draft specs
([#3544](#3544))
([d12eaa8](d12eaa8))
* **release:** Add digital signature to Toolbox binaries
([#3528](#3528))
([3f0f0af](3f0f0af))
* **tool/cloud-storage:** Configure object operation parameters
([#3529](#3529))
([d6dc5fe](d6dc5fe))
* **tool/cloud-storage:** Support configurable parameters
([#3478](#3478))
([bc2de2a](bc2de2a))
* **tools/dataplex-list-data-products:** Add dataplex-list-data-products
tool ([#3337](#3337))
([6dd669a](6dd669a))
* **tools/dataplex-get-data-product:** Add dataplex-get-data-product
tool ([#3499](#3499))
([7ea7a09](7ea7a09))
* **tools/dataplex-list-data-assets:** Add dataplex-list-data-assets
tool ([#3500](#3500))
([182f933](182f933))
* **tools/looker:** Support complex filter_expression parameter in
queries ([#3494](#3494))
([997fb8c](997fb8c))
* **tools/looker:** Support dynamic_fields parameter in queries
([#3507](#3507))
([cd22b89](cd22b89))


### Bug Fixes

* **tools/gda:** Support mTLS and GOOGLE_API_USE_MTLS_ENDPOINT for GDA
client ([#3460](#3460))
([cc2a61e](cc2a61e))
* **tools/looker-conversational-analytics:** Validate explore_references
shape instead of panicking
([#3531](#3531))
([b67419d](b67419d))
* **tool/looker-create-view-from-table:** Correct Looker API payload
structure
([#3515](#3515))
([18c539c](18c539c))


---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
github-actions Bot pushed a commit that referenced this pull request Jul 1, 2026
@Yuan325 @release-please
deploy: chore(main): release 1.6.0 (#3495)
4bc5103 
🤖 I have created a release *beep* *boop*
---

##
[1.6.0](v1.5.0...v1.6.0)
(2026-06-30)

### Features

* Support MCP 2026 draft specs
([#3544](#3544))
([d12eaa8](d12eaa8))
* **release:** Add digital signature to Toolbox binaries
([#3528](#3528))
([3f0f0af](3f0f0af))
* **tool/cloud-storage:** Configure object operation parameters
([#3529](#3529))
([d6dc5fe](d6dc5fe))
* **tool/cloud-storage:** Support configurable parameters
([#3478](#3478))
([bc2de2a](bc2de2a))
* **tools/dataplex-list-data-products:** Add dataplex-list-data-products
tool ([#3337](#3337))
([6dd669a](6dd669a))
* **tools/dataplex-get-data-product:** Add dataplex-get-data-product
tool ([#3499](#3499))
([7ea7a09](7ea7a09))
* **tools/dataplex-list-data-assets:** Add dataplex-list-data-assets
tool ([#3500](#3500))
([182f933](182f933))
* **tools/looker:** Support complex filter_expression parameter in
queries ([#3494](#3494))
([997fb8c](997fb8c))
* **tools/looker:** Support dynamic_fields parameter in queries
([#3507](#3507))
([cd22b89](cd22b89))

### Bug Fixes

* **tools/gda:** Support mTLS and GOOGLE_API_USE_MTLS_ENDPOINT for GDA
client ([#3460](#3460))
([cc2a61e](cc2a61e))
* **tools/looker-conversational-analytics:** Validate explore_references
shape instead of panicking
([#3531](#3531))
([b67419d](b67419d))
* **tool/looker-create-view-from-table:** Correct Looker API payload
structure
([#3515](#3515))
([18c539c](18c539c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 35c13ad
@BrewTestBot BrewTestBot mentioned this pull request Jul 1, 2026
Merged
github-actions Bot pushed a commit to pepe57/genai-toolbox that referenced this pull request Jul 1, 2026
@pull @release-please
deploy: chore(main): release 1.6.0 (googleapis#3495)
1cf1943 
🤖 I have created a release *beep* *boop*
---

##
[1.6.0](googleapis/mcp-toolbox@v1.5.0...v1.6.0)
(2026-06-30)

### Features

* Support MCP 2026 draft specs
([googleapis#3544](googleapis#3544))
([d12eaa8](googleapis@d12eaa8))
* **release:** Add digital signature to Toolbox binaries
([googleapis#3528](googleapis#3528))
([3f0f0af](googleapis@3f0f0af))
* **tool/cloud-storage:** Configure object operation parameters
([googleapis#3529](googleapis#3529))
([d6dc5fe](googleapis@d6dc5fe))
* **tool/cloud-storage:** Support configurable parameters
([googleapis#3478](googleapis#3478))
([bc2de2a](googleapis@bc2de2a))
* **tools/dataplex-list-data-products:** Add dataplex-list-data-products
tool ([googleapis#3337](googleapis#3337))
([6dd669a](googleapis@6dd669a))
* **tools/dataplex-get-data-product:** Add dataplex-get-data-product
tool ([googleapis#3499](googleapis#3499))
([7ea7a09](googleapis@7ea7a09))
* **tools/dataplex-list-data-assets:** Add dataplex-list-data-assets
tool ([googleapis#3500](googleapis#3500))
([182f933](googleapis@182f933))
* **tools/looker:** Support complex filter_expression parameter in
queries ([googleapis#3494](googleapis#3494))
([997fb8c](googleapis@997fb8c))
* **tools/looker:** Support dynamic_fields parameter in queries
([googleapis#3507](googleapis#3507))
([cd22b89](googleapis@cd22b89))

### Bug Fixes

* **tools/gda:** Support mTLS and GOOGLE_API_USE_MTLS_ENDPOINT for GDA
client ([googleapis#3460](googleapis#3460))
([cc2a61e](googleapis@cc2a61e))
* **tools/looker-conversational-analytics:** Validate explore_references
shape instead of panicking
([googleapis#3531](googleapis#3531))
([b67419d](googleapis@b67419d))
* **tool/looker-create-view-from-table:** Correct Looker API payload
structure
([googleapis#3515](googleapis#3515))
([18c539c](googleapis@18c539c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 35c13ad
github-actions Bot pushed a commit to rodineyw/mcp-toolbox that referenced this pull request Jul 1, 2026
@pull @release-please
deploy: chore(main): release 1.6.0 (googleapis#3495)
114b4fe 
🤖 I have created a release *beep* *boop*
---

##
[1.6.0](googleapis/mcp-toolbox@v1.5.0...v1.6.0)
(2026-06-30)

### Features

* Support MCP 2026 draft specs
([googleapis#3544](googleapis#3544))
([d12eaa8](googleapis@d12eaa8))
* **release:** Add digital signature to Toolbox binaries
([googleapis#3528](googleapis#3528))
([3f0f0af](googleapis@3f0f0af))
* **tool/cloud-storage:** Configure object operation parameters
([googleapis#3529](googleapis#3529))
([d6dc5fe](googleapis@d6dc5fe))
* **tool/cloud-storage:** Support configurable parameters
([googleapis#3478](googleapis#3478))
([bc2de2a](googleapis@bc2de2a))
* **tools/dataplex-list-data-products:** Add dataplex-list-data-products
tool ([googleapis#3337](googleapis#3337))
([6dd669a](googleapis@6dd669a))
* **tools/dataplex-get-data-product:** Add dataplex-get-data-product
tool ([googleapis#3499](googleapis#3499))
([7ea7a09](googleapis@7ea7a09))
* **tools/dataplex-list-data-assets:** Add dataplex-list-data-assets
tool ([googleapis#3500](googleapis#3500))
([182f933](googleapis@182f933))
* **tools/looker:** Support complex filter_expression parameter in
queries ([googleapis#3494](googleapis#3494))
([997fb8c](googleapis@997fb8c))
* **tools/looker:** Support dynamic_fields parameter in queries
([googleapis#3507](googleapis#3507))
([cd22b89](googleapis@cd22b89))

### Bug Fixes

* **tools/gda:** Support mTLS and GOOGLE_API_USE_MTLS_ENDPOINT for GDA
client ([googleapis#3460](googleapis#3460))
([cc2a61e](googleapis@cc2a61e))
* **tools/looker-conversational-analytics:** Validate explore_references
shape instead of panicking
([googleapis#3531](googleapis#3531))
([b67419d](googleapis@b67419d))
* **tool/looker-create-view-from-table:** Correct Looker API payload
structure
([googleapis#3515](googleapis#3515))
([18c539c](googleapis@18c539c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 35c13ad
github-actions Bot pushed a commit to Jaleel-zhu/genai-toolbox that referenced this pull request Jul 1, 2026
@pull @release-please
deploy: chore(main): release 1.6.0 (googleapis#3495)
3c04839 
🤖 I have created a release *beep* *boop*
---

##
[1.6.0](googleapis/mcp-toolbox@v1.5.0...v1.6.0)
(2026-06-30)

### Features

* Support MCP 2026 draft specs
([googleapis#3544](googleapis#3544))
([d12eaa8](googleapis@d12eaa8))
* **release:** Add digital signature to Toolbox binaries
([googleapis#3528](googleapis#3528))
([3f0f0af](googleapis@3f0f0af))
* **tool/cloud-storage:** Configure object operation parameters
([googleapis#3529](googleapis#3529))
([d6dc5fe](googleapis@d6dc5fe))
* **tool/cloud-storage:** Support configurable parameters
([googleapis#3478](googleapis#3478))
([bc2de2a](googleapis@bc2de2a))
* **tools/dataplex-list-data-products:** Add dataplex-list-data-products
tool ([googleapis#3337](googleapis#3337))
([6dd669a](googleapis@6dd669a))
* **tools/dataplex-get-data-product:** Add dataplex-get-data-product
tool ([googleapis#3499](googleapis#3499))
([7ea7a09](googleapis@7ea7a09))
* **tools/dataplex-list-data-assets:** Add dataplex-list-data-assets
tool ([googleapis#3500](googleapis#3500))
([182f933](googleapis@182f933))
* **tools/looker:** Support complex filter_expression parameter in
queries ([googleapis#3494](googleapis#3494))
([997fb8c](googleapis@997fb8c))
* **tools/looker:** Support dynamic_fields parameter in queries
([googleapis#3507](googleapis#3507))
([cd22b89](googleapis@cd22b89))

### Bug Fixes

* **tools/gda:** Support mTLS and GOOGLE_API_USE_MTLS_ENDPOINT for GDA
client ([googleapis#3460](googleapis#3460))
([cc2a61e](googleapis@cc2a61e))
* **tools/looker-conversational-analytics:** Validate explore_references
shape instead of panicking
([googleapis#3531](googleapis#3531))
([b67419d](googleapis@b67419d))
* **tool/looker-create-view-from-table:** Correct Looker API payload
structure
([googleapis#3515](googleapis#3515))
([18c539c](googleapis@18c539c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 35c13ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drstrangelooker drstrangelooker drstrangelooker approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@drstrangelooker drstrangelooker

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Looker create_view_from_table tool fails with 500 error due to incorrect API payload

2 participants

@dhruvingandhi @drstrangelooker