Skip to content

Revert "docs: Add Banner Configuration"#3525

Merged
Yuan325 merged 1 commit into
mainfrom
revert-3274-add-banner
Jun 25, 2026
Merged

Revert "docs: Add Banner Configuration"#3525
Yuan325 merged 1 commit into
mainfrom
revert-3274-add-banner

Conversation

@dishaprakash

Copy link
Copy Markdown
Contributor

Reverts #3274

@dishaprakash dishaprakash requested a review from a team as a code owner June 25, 2026 15:54

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the general announcement banner with a sticky migration banner directing users to the new documentation site, updating the layout scripts and configuration accordingly. The reviewer feedback highlights that conditionally loading custom-layout.js based on the banner status disables other critical layout adjustments, suggesting instead to load the script unconditionally and use a global configuration flag to toggle the banner. Additionally, the reviewer recommends removing the newly added migration-banner.js file as it is redundant and unused.

Comment thread .hugo/layouts/partials/hooks/head-end.html
Comment thread .hugo/static/js/custom-layout.js
Comment thread .hugo/static/js/migration-banner.js
@Yuan325 Yuan325 enabled auto-merge (squash) June 25, 2026 16:26
@Yuan325 Yuan325 merged commit 1cbee50 into main Jun 25, 2026
27 checks passed
@Yuan325 Yuan325 deleted the revert-3274-add-banner branch June 25, 2026 16:28
@github-actions

Copy link
Copy Markdown
Contributor

🧨 Preview deployments removed.

Cloudflare Pages environments for pr-3525 have been deleted.

github-actions Bot pushed a commit that referenced this pull request Jun 25, 2026
github-actions Bot pushed a commit to pepe57/genai-toolbox that referenced this pull request Jun 25, 2026
github-actions Bot pushed a commit to rodineyw/mcp-toolbox that referenced this pull request Jun 25, 2026
github-actions Bot pushed a commit to Jaleel-zhu/genai-toolbox that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants