feat(tool/cloud-storage): configure object operation parameters#3529
Open
huangjiahua wants to merge 1 commit into
Open
feat(tool/cloud-storage): configure object operation parameters#3529huangjiahua wants to merge 1 commit into
huangjiahua wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces tool-level configuration options for Google Cloud Storage (GCS) tools, allowing parameters like bucket, source_bucket, destination_bucket, destination_dir, and overwrite to be pre-configured. When configured, these parameters are hidden from the LLM's parameter list. It also adds path resolution safety via ResolveWithinDir to prevent directory traversal attacks during downloads, updates the corresponding documentation pages, and adds comprehensive unit and integration tests. I have no feedback to provide as there are no review comments to evaluate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Description
Completes configurable parameter support for the remaining Cloud Storage object tools, using the functional-option parameter constructors introduced in #3314.
This change adds optional config-backed values for download, upload, write, copy, move, and delete object tools. Configured fields are hidden from the runtime manifest while zero-config tools keep their current parameter schemas. Download also supports a configured
destination_dir, where the runtimedestinationremains visible but becomes a relative path constrained under that directory.2. PR Checklist
!if this involves a breaking change3. Issue Reference
Related to #3314 🦕