feat: allow to skip wrapping data into custom types #1490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
leahecole
reviewed
Jul 2, 2025
| rows: TableRow[], | ||
| options: { | ||
| wrapIntegers: boolean | IntegerTypeCastOptions; | ||
| skipWrapCustomTypes?: boolean; |
There was a problem hiding this comment.
nit - can this be the last option? I know order isn't necessarily preserved but I feel like we should have these options in the order in which we have added them
There was a problem hiding this comment.
additional comment on this line - Any reason why we can't call this wrapCustomTypes? I know it would flip the boolean logic later on, but it would be in line with the wrapIntegers naming scheme
| value: any, | ||
| options: { | ||
| wrapIntegers: boolean | IntegerTypeCastOptions; | ||
| skipWrapCustomTypes?: boolean; |
There was a problem hiding this comment.
same note about order of options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR on an idea to avoid the issue reported on #1384, where for some customers, having the custom types actually makes it harder to manipulate data. Naming is hard, not sure what is the best option name here.
Fixes #1384
Fixes #1489