feat: query client based on autogen package #1491
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xl
leahecole
reviewed
Jul 8, 2025
There was a problem hiding this comment.
Some meta questions
- we had talked about intelligently handing off to BQ storage read where appropriate. I know this is a proof of concept and it's early, but if this is still in scope, is there anything we can change with this implementation to make sure it's friendly to us making that change later?
- for the various converter utilities, are these duplicated in storage at all? if so, is there a way for us to not be duplicating them?
- the question for the skeptics: are all of the conveniences found here absolute must haves, or are there some things that are "would be nice"s that we can begin without?
| /** | ||
| * QueryClient is a client for running queries in BigQuery. | ||
| */ | ||
| export class QueryClient { |
There was a problem hiding this comment.
Interesting - why have an entirely new client rather than have this be part of the central client?
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
There was a problem hiding this comment.
Will these utils only be useful for queries, or are they also useful with other clients?
| /** | ||
| * RowIterator iterates over the results of a query. | ||
| */ | ||
| export class RowIterator { |
There was a problem hiding this comment.
can you use the iterator without the reader, or is this only ever used in the context of the reader? If only ever coupled with the reader, my nit would be to have them in the same file
|
Updated the PR to use preview-9.x as base |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft on new query experience using the new bigquery/v2 client. Will break it down into smaller PR down the line, just testing the interface across languages to settle on a good interface.
Based on Go implementation googleapis/google-cloud-go#12512