-
Notifications
You must be signed in to change notification settings - Fork 48
feat: add DataFrame.to_pandas_batches()
to download large DataFrame
objects
#136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
c35523c
refactor: make `to_pandas()` call `to_arrow()` and use local dtypes i…
tswast 9f5865c
Merge branch 'main' into b280662868-to_arrow
tswast c2f9d72
use integer_object_nulls=True to preserve NA/NaN distinction
tswast 7ccb61d
allow NUMERIC/BIGNUMERIC to cast to FLOAT64
tswast 829cf99
better workaround for Float64Dtype NaNs
tswast c158780
Merge remote-tracking branch 'origin/main' into b280662868-to_arrow
tswast 3a90214
fix type error
tswast 8bdfd79
add unit tests for extreme values
tswast db81a1c
fix tests on latest pandas
tswast b25112b
mypy fixes
tswast a3705f9
fix mod tests
tswast 33a9d9f
Merge remote-tracking branch 'origin/main' into b280662868-to_arrow
tswast 1a7b2d7
feat: add `DataFrame.to_pandas_batches()` to download large `DataFram…
tswast 0c23388
Merge branch 'main' into b280662868-to_pandas_batches
tswast c4a8b15
allow copies
tswast 239e5ef
allow copies only for contiguous arrays
tswast ea4d9df
test with chunked_array
tswast 38dba2a
Merge remote-tracking branch 'origin/main' into b280662868-to_pandas_…
tswast 2f225dd
Merge branch 'main' into b280662868-to_pandas_batches
tswast e1e291d
explain type: ignore
tswast 3166a65
Merge remote-tracking branch 'origin/main' into b280662868-to_pandas_…
tswast 2e218e9
Merge branch 'b280662868-to_pandas_batches' of github.com:googleapis/…
tswast 6dd5aae
Merge branch 'main' into b280662868-to_pandas_batches
gcf-merge-on-green[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious what's the error here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bigframes/core/blocks.py:434: error: Incompatible types in assignment (expression has type "Sequence[Hashable]", variable has type "list[str]") [assignment]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though list[str] is a sequence of hashable objects, I think maybe type covariance can't kick in. I'll try with some casts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I had it opposite. pandas says "names" is
list[str]
, but actually I don't think that's true.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed pandas-dev/pandas-stubs#804 and commented with an explanation.