Skip to content

feat: Add isin local execution to hybrid engine #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions bigframes/core/compile/polars/compiler.py
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,30 @@ def compile_join(self, node: nodes.JoinNode):
left, right, node.type, left_on, right_on, node.joins_nulls
)

@compile_node.register
def compile_isin(self, node: nodes.InNode):
left = self.compile_node(node.left_child)
right = self.compile_node(node.right_child).unique(node.right_col.id.sql)
right = right.with_columns(pl.lit(True).alias(node.indicator_col.sql))

left_ex, right_ex = lowering._coerce_comparables(node.left_col, node.right_col)

left_pl_ex = self.expr_compiler.compile_expression(left_ex)
right_pl_ex = self.expr_compiler.compile_expression(right_ex)

joined = left.join(
right,
how="left",
left_on=left_pl_ex,
right_on=right_pl_ex,
# Note: join_nulls renamed to nulls_equal for polars 1.24
join_nulls=node.joins_nulls, # type: ignore
coalesce=False,
)
passthrough = [pl.col(id) for id in left.columns]
indicator = pl.col(node.indicator_col.sql).fill_null(False)
return joined.select((*passthrough, indicator))

def _ordered_join(
self,
left_frame: pl.LazyFrame,
Expand Down
10 changes: 10 additions & 0 deletions bigframes/core/rewrite/schema_binding.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,16 @@ def bind_schema_to_node(
node,
conditions=conditions,
)
if isinstance(node, nodes.InNode):
return dataclasses.replace(
node,
left_col=ex.ResolvedDerefOp.from_field(
node.left_child.field_by_id[node.left_col.id]
),
right_col=ex.ResolvedDerefOp.from_field(
node.right_child.field_by_id[node.right_col.id]
),
)

if isinstance(node, nodes.AggregateNode):
aggregations = []
Expand Down
1 change: 1 addition & 0 deletions bigframes/session/polars_executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
nodes.FilterNode,
nodes.ConcatNode,
nodes.JoinNode,
nodes.InNode,
)

_COMPATIBLE_SCALAR_OPS = (
Expand Down
19 changes: 19 additions & 0 deletions tests/system/small/engines/test_join.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,22 @@ def test_engines_cross_join(
result, _ = scalars_array_value.relational_join(scalars_array_value, type="cross")

assert_equivalence_execution(result.node, REFERENCE_ENGINE, engine)


@pytest.mark.parametrize("engine", ["polars", "bq"], indirect=True)
@pytest.mark.parametrize(
("left_key", "right_key"),
[
("int64_col", "float64_col"),
("float64_col", "int64_col"),
("int64_too", "int64_col"),
],
)
def test_engines_isin(
scalars_array_value: array_value.ArrayValue, engine, left_key, right_key
):
result, _ = scalars_array_value.isin(
scalars_array_value, lcol=left_key, rcol=right_key
)

assert_equivalence_execution(result.node, REFERENCE_ENGINE, engine)