Skip to content

fix: remove pandas-gbq client ID for authentication #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025
Merged

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Jun 3, 2025

pandas-gbq's client ID has been failing for some time due to Error 400: redirect_uri_mismatch. Since it's only used for a fallback if no application default credentials are available, it's probably OK to use pydata-google-auth's client ID instead.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

pandas-gbq's client ID has been failing for some time due to `Error 400: redirect_uri_mismatch`. Since it's only used for a fallback if no application default credentials are available, it's probably OK to use pydata-google-auth's client ID instead.
@tswast tswast requested review from a team as code owners June 3, 2025 15:49
@tswast tswast requested review from Linchin and shuoweil June 3, 2025 15:49
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-pandas API. labels Jun 3, 2025
@GarrettWu GarrettWu removed their assignment Jun 3, 2025
Copy link

@mrfaizal mrfaizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming we're ok removing a fallback option. since it wasn't working anyways, this is no worse than before.

@tswast tswast merged commit 8bb7401 into main Jun 3, 2025
26 checks passed
@tswast tswast deleted the tswast-patch-1 branch June 3, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants