-
Notifications
You must be signed in to change notification settings - Fork 138
Service Account Impersonation #906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lihan
wants to merge
2
commits into
googleapis:main
Choose a base branch
from
CoverGenius:impersonation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,6 +64,7 @@ def url_with_everything(): | |
"&use_query_cache=true" | ||
"&write_disposition=WRITE_APPEND" | ||
"&user_supplied_client=true" | ||
"&[email protected]" | ||
) | ||
|
||
|
||
|
@@ -78,6 +79,7 @@ def test_basic(url_with_everything): | |
job_config, | ||
list_tables_page_size, | ||
user_supplied_client, | ||
with_subject, | ||
) = parse_url(url_with_everything) | ||
|
||
assert project_id == "some-project" | ||
|
@@ -89,6 +91,7 @@ def test_basic(url_with_everything): | |
assert credentials_base64 == "eyJrZXkiOiJ2YWx1ZSJ9Cg==" | ||
assert isinstance(job_config, QueryJobConfig) | ||
assert user_supplied_client | ||
assert with_subject | ||
|
||
|
||
@pytest.mark.parametrize( | ||
|
@@ -191,6 +194,7 @@ def test_empty_with_non_config(): | |
job_config, | ||
list_tables_page_size, | ||
user_supplied_credentials, | ||
with_subject, | ||
) = url | ||
|
||
assert project_id is None | ||
|
@@ -202,6 +206,7 @@ def test_empty_with_non_config(): | |
assert job_config is None | ||
assert list_tables_page_size is None | ||
assert not user_supplied_credentials | ||
assert not with_subject | ||
|
||
|
||
def test_only_dataset(): | ||
|
@@ -215,6 +220,7 @@ def test_only_dataset(): | |
credentials_base64, | ||
job_config, | ||
list_tables_page_size, | ||
with_subject, | ||
user_supplied_credentials, | ||
) = url | ||
|
||
|
@@ -227,6 +233,7 @@ def test_only_dataset(): | |
assert list_tables_page_size is None | ||
assert isinstance(job_config, QueryJobConfig) | ||
assert not user_supplied_credentials | ||
assert not user_supplied_credentials | ||
# we can't actually test that the dataset is on the job_config, | ||
# since we take care of that afterwards, when we have a client to fill in the project | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: assert the exact value, instead of Boolean value