Skip to content

Conversation

@musicinmybrain
Copy link

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass no code changes
  • Code coverage does not decrease (if any source code was changed) no code changes
  • Appropriate docs were updated (if necessary) N/A

(Partially) fixes #324 🦕

After the first commit in this PR:

$ pip install .[testing]
[… no warnings, correctly install pytest …]
$ ls -l _e/lib/python3.14/site-packages/google_crc32c/_crc32c.c
-rw-r--r--. 1 ben ben 1428 Dec 16 10:35 _e/lib/python3.14/site-packages/google_crc32c/_crc32c.c

Since migrating

[options.package_data]
google_crc32c =
    py.typed

to

[tool.setuptools.package-data]
google_crc32c = ["py.typed"]

didn’t have the desired effect of not shipping the _crc32c.c source file in the wheel, and I don’t know how to acheive that, I just removed the package data configuration. Aftwerard, py.typed is still present in the wheel.

This PR does at least fix the testing extra.

@musicinmybrain musicinmybrain requested a review from a team as a code owner December 16, 2025 10:41
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Dec 16, 2025
@musicinmybrain musicinmybrain changed the title Migrate extras config to pyproject.toml chore: Migrate extras config to pyproject.toml Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.8.0 missing testing extra, ships unnecessary C source

2 participants