feat: introduce from_json_schema classmethod to Schema class to allow conversion from JSONSchema class object to Schema class object #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
copybara/748500443
branch
2 times, most recently
from
49383fb to
ae72c4c
Compare
copybara-service
bot
force-pushed
the
copybara/748500443
branch
2 times, most recently
from
6cbbc12 to
cbcd158
Compare
… conversion from JSONSchema class object to Schema class object PiperOrigin-RevId: 750027090
copybara-service
bot
force-pushed
the
copybara/748500443
branch
from
cbcd158 to
899fa1a
Compare
|
Hey @yyyu-google , thanks for adding this functionality. One thing though, we still have to manually convert our schema to the SDK’s JSONSchema class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: introduce from_json_schema classmethod to Schema class to allow conversion from JSONSchema class object to Schema class object