fix(owl-bot): fix two timing related bugs (#1413)

googleapis · Feb 11, 2021 · 8a60f32 · 8a60f32
1 parent 1f7654d
commit 8a60f32
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 2 deletions.
diff --git a/packages/gcf-utils/src/gcf-utils.ts b/packages/gcf-utils/src/gcf-utils.ts
@@ -151,7 +151,7 @@ export class GCFBootstrapper {
       this.probot = createProbot({overrides: cfg});
     }
 
-    this.probot.load(appFn);
+    await this.probot.load(appFn);
 
     return this.probot;
   }

diff --git a/packages/owl-bot/src/handlers.ts b/packages/owl-bot/src/handlers.ts
@@ -66,7 +66,12 @@ export async function onPostProcessorPublished(
         installation: configs.installationId,
       });
       // TODO(bcoe): switch updatedAt to date from PubSub payload:
-      createOnePullRequestForUpdatingLock(configsStore, octokit, repo, lock);
+      await createOnePullRequestForUpdatingLock(
+        configsStore,
+        octokit,
+        repo,
+        lock
+      );
     }
   }
 }

diff --git a/packages/owl-bot/test/owl-bot.ts b/packages/owl-bot/test/owl-bot.ts
@@ -119,4 +119,32 @@ describe('owlBot', () => {
       githubMock.done();
     });
   });
+  it('loads async app before handling request', async () => {
+    const probot = createProbot({
+      overrides: {
+        githubToken: 'abc123',
+        Octokit: ProbotOctokit.defaults({
+          retry: {enabled: false},
+          throttle: {enabled: false},
+        }),
+      },
+    });
+    await probot.load(async (app: Probot) => {
+      await new Promise(resolve => {
+        setTimeout(() => {
+          return resolve(undefined);
+        }, 100);
+      });
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      owlBot('abc123', app, sandbox.stub() as any);
+    });
+    const loggerStub = sandbox.stub(logger, 'info');
+    await probot.receive({
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      name: 'pubsub.message' as any,
+      payload: {},
+      id: 'abc123',
+    });
+    sandbox.assert.calledOnce(loggerStub);
+  });
 });