Add sdp params to step-5&6 to improve compatibility#92
Add sdp params to step-5&6 to improve compatibility#92platy wants to merge 1 commit intogooglecodelabs:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
e2536f1 to
701e0a9
Compare
|
CLAs look good, thanks! |
|
Hey, I've just seen this is not merged - I'm not working with webrtc any more and can't remember what this is but can we merge it or close it? |
I've implemented @nitobuendia 's suggestions on #33.
I don't know the purpose of the 2 extra fields but it seems they are only needed when there is more than one Ice candidate - which seems to be more frequent on firefox than chrome when testing locally