Make filters generic over the packet buffer #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reserve was being calculated incorrectly, since it's additional bytes from the current position
Jake-Shadle
requested review from
markmandel,
XAMPPRocky and
koslib
as code owners
XAMPPRocky
approved these changes
Dec 20, 2024
|
Build Succeeded 🥳 Build Id: 71d0cf62-9d3e-4721-a227-f61fbe1d5d41 The following development images have been built, and will exist for the next 30 days: To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
Filterso that both read and write take a generic<P: Packet>parameter instead of a concretePoolBuffer. This change prepares for the new XDP buffer, so doesn't do anything right now, but makes it easier to review by splitting out this PR first.