feat: Add initial nmap-service-probes crate #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Jake-Shadle
approved these changes
Jan 13, 2025
XAMPPRocky
force-pushed
the
ep/nmap-probes
branch
from
7538320 to
da565c7
Compare
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Succeeded 🥳 Build Id: b0baf8fb-dadd-46dd-8567-fcdcf9fa075c The following development images have been built, and will exist for the next 30 days: To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was mentioned that we should try to parse out pings from scanners separately, so that we can flag those packets separately from just "dropped packets". This PR adds the first step to doing that, which is adding support for the
nmap-service-probesfile format. This format is used by nmap for it to define its probes, and they have a large file that represents all of the probes they use. This gives us easy programmatic access to those payloads. I intend to followup with a PR that uses this crate to make a code generator so we can generate a set of types and constants we can use in the quilkin crate, but I wanted to make the crate PR separate since it is completely independent.