New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move network servers under publish flags #1065

Closed

XAMPPRocky wants to merge 1 commit into main from ep/publish-cli

Collaborator

XAMPPRocky commented Jan 17, 2025

This is the first big step in my CLI refactoring, the goal is to move away from the distinct modes (agent, proxy, relay, etc) towards allowing users to specify individual components they want to enable (for example, to have the same functionality as the old proxy you would write --publish.udp --publish.qcmp --publish.phoenix). The intention here is to simplify both our code and the concepts around them and to make deployments more composable. This will reduce a lot of test surface because it will make writing tests for specific publishers much easier, and allow us to remove redundant code paths where we had to handle components that were shared between two modes but were unused by one mode.

Currently the modes are still included, because I wanted to divide the PR up, the intention is make a followup that applies the same logic to configuration providers and that will remove the modes entirely.

XAMPPRocky requested review from koslib and Jake-Shadle as code owners

January 17, 2025 12:57

github-actions bot added kind/other size/l labels

Jake-Shadle approved these changes

View reviewed changes

Collaborator

Jake-Shadle left a comment

Approving, though the publish term is not fully making sense to me.

Collaborator Author

XAMPPRocky commented Jan 17, 2025

though the publish term is not fully making sense to me.

I thought about it in the sense of it being services that quilkin "exposes" or "publishes" to the user. Also in the sense of "config provider" being an input to quilkin, the "publisher" is output of quilkin. I was thinking about making config providers under a subscribe flag so it might feel more intuitive with those added. I am open to better suggestions though this was just me looking at a bunch of words and trying to find the one that matches the intent.

XAMPPRocky force-pushed the ep/publish-cli branch 2 times, most recently from 6de690e to d432a54 Compare

January 17, 2025 17:03

Collaborator

Jake-Shadle commented Jan 17, 2025

No, that makes sense, I guess I always just first associate publish with like, releases/artifacts etc.

XAMPPRocky force-pushed the ep/publish-cli branch from d432a54 to d0212ed Compare

January 20, 2025 11:00

github-actions bot added size/xl and removed size/l labels

github-actions bot commented Jan 20, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

XAMPPRocky force-pushed the ep/publish-cli branch from d0212ed to fc16630 Compare

January 20, 2025 11:47

github-actions bot commented Jan 20, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

XAMPPRocky enabled auto-merge (squash)

January 20, 2025 11:53

github-actions bot commented Jan 20, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

XAMPPRocky force-pushed the ep/publish-cli branch from fb1e65a to 4477d06 Compare

January 20, 2025 12:23

github-actions bot commented Jan 20, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment

github-actions bot commented Jan 20, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

XAMPPRocky force-pushed the ep/publish-cli branch from c8ac17d to 0094bb9 Compare

January 20, 2025 12:43

github-actions bot commented Jan 20, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

XAMPPRocky force-pushed the ep/publish-cli branch from 0094bb9 to f0f9abf Compare

January 20, 2025 12:58

github-actions bot commented Jan 20, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

XAMPPRocky force-pushed the ep/publish-cli branch from f0f9abf to 48d45a6 Compare

January 20, 2025 13:03

github-actions bot commented Jan 20, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

XAMPPRocky force-pushed the ep/publish-cli branch from 48d45a6 to d15efe7 Compare

January 20, 2025 13:42

github-actions bot commented Jan 20, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

XAMPPRocky force-pushed the ep/publish-cli branch from d15efe7 to 75400d4 Compare

January 20, 2025 14:13

github-actions bot commented Jan 20, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions bot commented Jan 22, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

XAMPPRocky force-pushed the ep/publish-cli branch from b10f6ea to 7cdddce Compare

January 22, 2025 12:11

github-actions bot commented Jan 22, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

XAMPPRocky force-pushed the ep/publish-cli branch from 7cdddce to 1f8d168 Compare

January 22, 2025 12:17

github-actions bot commented Jan 22, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

XAMPPRocky force-pushed the ep/publish-cli branch from 1f8d168 to 400f359 Compare

January 22, 2025 12:30

github-actions bot commented Jan 22, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

XAMPPRocky force-pushed the ep/publish-cli branch from 400f359 to b9601a6 Compare

January 22, 2025 12:43

github-actions bot commented Jan 22, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

XAMPPRocky force-pushed the ep/publish-cli branch from b9601a6 to d7ab5da Compare

January 22, 2025 13:12

github-actions bot commented Jan 22, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

XAMPPRocky force-pushed the ep/publish-cli branch from d7ab5da to e2b7ad8 Compare

January 22, 2025 13:23

github-actions bot commented Jan 22, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

XAMPPRocky force-pushed the ep/publish-cli branch from e2b7ad8 to cdfcf41 Compare

January 22, 2025 13:35

github-actions bot commented Jan 22, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

XAMPPRocky force-pushed the ep/publish-cli branch from cdfcf41 to f22fbc4 Compare

January 22, 2025 13:54

github-actions bot commented Jan 22, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

XAMPPRocky force-pushed the ep/publish-cli branch from f22fbc4 to 9667a06 Compare

January 22, 2025 14:11

github-actions bot commented Jan 22, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

XAMPPRocky force-pushed the ep/publish-cli branch from 9667a06 to 61fd192 Compare

January 22, 2025 14:36

github-actions bot commented Jan 22, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

XAMPPRocky force-pushed the ep/publish-cli branch from 61fd192 to 02306d5 Compare

January 22, 2025 15:14

github-actions bot commented Jan 22, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.


          refactor: Move network servers under publish flags

6ffd9a8

XAMPPRocky force-pushed the ep/publish-cli branch from 02306d5 to 6ffd9a8 Compare

January 22, 2025 15:31

github-actions bot commented Jan 22, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Collaborator

quilkin-bot commented Jan 22, 2025

Build Failed 😭

Build Id: 4a46ce53-ab56-4ebe-bb4d-39500f247f4c

Status: FAILURE

To get permission to view the Cloud Build view, join the quilkin-discuss Google Group.

Filter with the Git Commit 6ffd9a8 within us-docker.pkg.dev/quilkin/ci//quilkin to see if a development image is available from this build, and can be used for debugging purposes.

Development images are retained for at least 30 days.

XAMPPRocky mentioned this pull request

move network services to --services flag #1074

Merged

XAMPPRocky closed this

auto-merge was automatically disabled

January 22, 2025 19:11

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/other size/xl