-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XDP CLI options and initialization code #1069
Merged
Merged
+178
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pthread_cancel is super broken
Since we just include the eBPF program directly we need to force the alignment to be what object::Object::parse expects for 64-bit ELF files
XAMPPRocky
reviewed
Jan 20, 2025
Build Succeeded 🥳 Build Id: 4d82992d-2613-4e7d-b615-550bd0d150e8 The following development images have been built, and will exist for the next 30 days: To build this version:
|
XAMPPRocky
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the support for several XDP specific options, and the initialization code to bring up the XDP I/O loop, falling back to io-uring if setup fails for some reason. This PR always falls back to io-uring at the moment, this is just to get the code in so that it can be iterated on in further PRs, as I only tested that we can spinup quilkin proxy using XDP and shut it down cleanly, not the actual I/O which I'm leaving for tomorrow.
Fixed several bugs:
pthread_cancel
is apparently super not good and was causing a crash at shutdown due to signal shenanigans, so I just replaced it with an atomic bool for now