Add lz4 support #868
Merged
Add lz4 support #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake-Shadle
requested review from
markmandel,
XAMPPRocky and
koslib
as code owners
markmandel
reviewed
Nov 22, 2023
There was a problem hiding this comment.
Except for those type issues, implementation looks good.
Some documentation on the new features here would round this off nicely: https://github.com/googleforgames/quilkin/blob/main/docs/src/services/proxy/filters/compress.md
Takes the compressor changes made in ep/iouring and ports them to a clean branch
XAMPPRocky
approved these changes
Nov 23, 2023
|
Build Succeeded 🥳 Build Id: ec3acd80-30f2-49ad-a569-0f81fd223187 The following development images have been built, and will exist for the next 30 days: To build this version: |
markmandel
added
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for LZ4 compression. Initial benchmarks with (seeded) randomized data shows that snappy is easily beating it on both compression and decompression, but thought I might as well PR it.
Resolves: #862