This repository was archived by the owner on May 15, 2023. It is now read-only.
Publish Docker Images to GH Packages on merge with main#86
Open
jaimehisao wants to merge 6 commits intomainfrom
Open
Publish Docker Images to GH Packages on merge with main#86jaimehisao wants to merge 6 commits intomainfrom
jaimehisao wants to merge 6 commits intomainfrom
Conversation
jaimehisao
changed the title
jaimehisao
requested review from
Domene99,
anniefu,
dmosc and
ssmall
as code owners
Domene99
reviewed
Aug 25, 2020
Contributor
Domene99
left a comment
Domene99
left a comment
There was a problem hiding this comment.
where you not going to use matrix something for this pr?
ssmall
suggested changes
Aug 25, 2020
Comment on lines
+12
to
+42
| - name: Build Frontend Docker image | ||
| working-directory: ./app | ||
| run: | | ||
| docker login docker.pkg.github.com -u ${{ secrets.USERNAME }} --password ${{ secrets.GITHUB_TOKEN }} | ||
| docker build . --file Dockerfile --tag frontend | ||
| docker tag frontend docker.pkg.github.com/googleinterns/major-tom/frontend | ||
| docker push docker.pkg.github.com/googleinterns/major-tom/frontend | ||
| - name: Build Backend Docker image | ||
| working-directory: ./server | ||
| run: | | ||
| docker build . --file Dockerfile --tag backend | ||
| docker tag backend docker.pkg.github.com/googleinterns/major-tom/backend | ||
| docker push docker.pkg.github.com/googleinterns/major-tom/backend | ||
| - name: Build Keywords Docker image | ||
| working-directory: ./services/keywords | ||
| run: | | ||
| docker build . --file Dockerfile --tag keywords | ||
| docker tag keywords docker.pkg.github.com/googleinterns/major-tom/keywords | ||
| docker push docker.pkg.github.com/googleinterns/major-tom/keywords | ||
| - name: Build Search Docker image | ||
| working-directory: ./services/search | ||
| run: | | ||
| docker build . --file Dockerfile --tag search | ||
| docker tag search docker.pkg.github.com/googleinterns/major-tom/search | ||
| docker push docker.pkg.github.com/googleinterns/major-tom/search | ||
| - name: Build Parser Docker image | ||
| working-directory: ./services/parser-database | ||
| run: | | ||
| docker build . --file Dockerfile --tag parser-database | ||
| docker tag parser-database docker.pkg.github.com/googleinterns/major-tom/parser-database | ||
| docker push docker.pkg.github.com/googleinterns/major-tom/parser-database |
Contributor
There was a problem hiding this comment.
the docker login could be moved to a separate step and then the build step could be parameterized as a matrix job
dmosc
reviewed
Aug 26, 2020
Contributor
dmosc
left a comment
dmosc
left a comment
There was a problem hiding this comment.
Very nice!
Left some comments below.
| - name: Build Parser Docker image | ||
| working-directory: ./services/parser-database | ||
| run: | | ||
| docker build . --file Dockerfile --tag parser-database |
Contributor
There was a problem hiding this comment.
I am pretty confident you can omit the --file flag as Docker looks for that file by default.
| run: | | ||
| docker login docker.pkg.github.com -u ${{ secrets.USERNAME }} --password ${{ secrets.GITHUB_TOKEN }} | ||
| docker build . --file Dockerfile --tag frontend | ||
| docker tag frontend docker.pkg.github.com/googleinterns/major-tom/frontend |
Contributor
There was a problem hiding this comment.
Correct me if I am wrong but, are these URL's correct? I thought that for pushing to Google's Container Registry you had to prefix your images with the following format:
gcr.io/$PROJECT_ID/$IMAGE_NAME
i.e. gcr.io/major-tom-123/frontend
Contributor
There was a problem hiding this comment.
I think this pr is about publishing our latest image to the repo not to gcp's container registry
anniefu
reviewed
Aug 26, 2020
| @@ -0,0 +1,42 @@ | |||
| name: Build Docker Images & Push to Registry | |||
|
|
|||
There was a problem hiding this comment.
I assume this is a cloudbuild yaml? I would leave cloudbuild in the name somewhere if so
| working-directory: ./server | ||
| run: | | ||
| docker build . --file Dockerfile --tag backend | ||
| docker tag backend docker.pkg.github.com/googleinterns/major-tom/backend |
There was a problem hiding this comment.
Isn't this tag lost if you don't push it with this tag too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.