fix: zIndex for Clustering #1484
Conversation
kikoso
changed the title
| @@ -906,6 +910,13 @@ protected void onClusterItemUpdated(@NonNull T item, @NonNull Marker marker) { | |||
| protected void onBeforeClusterRendered(@NonNull Cluster<T> cluster, @NonNull MarkerOptions markerOptions) { | |||
| // TODO: consider adding anchor(.5, .5) (Individual markers will overlap more often) | |||
| markerOptions.icon(getDescriptorForCluster(cluster)); | |||
| Iterator<T> iterator = cluster.getItems().iterator(); | |||
There was a problem hiding this comment.
This code next more explanation. What is the goal of this code and how does it work?
It also strike me as very odd. I am not used to seeing an iterator w/o a loop. This has a strange code smell to it. If the intent is to only use the second element of the cluster, this seems like a very strange way to go about it.
There was a problem hiding this comment.
Cluster.getItems() returns Collection.
Since there are no methods like get in the Collection interface, I use iterator to get the first element.
I see another way to do this:
ArrayList<T> items = new ArrayList<>(cluster.getItems());
Do you think this option would be clearer?
There was a problem hiding this comment.
Hi @Programmeister .
That solutions sounds a bit better than the current iterator one IMO.
…erRendered and onBeforeClusterItemRendered
Programmeister
force-pushed
the
bugfix/1424
branch
from
d2658e3 to
ab01358
Compare
Add zIndex to markerOptions in onBeforeClusterRendered and onBeforeClusterItemRendered
Fixes #1424