Skip to content

Conversation

mschwarzl
Copy link

Copy link

google-cla bot commented Aug 27, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@saelo saelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, thanks! Some comments about splitting the PR but otherwise this looks good

@@ -1,17 +1,3 @@
// Copyright 2020 Google LLC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes to this file or create a separate PR :)

@@ -239,9 +239,21 @@ public struct Code: Collection {
throw FuzzilliError.codeVerificationError("variable \(input) is not visible anymore")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a separate PR for the changes to the compiler and parser. Thanks!

@@ -13,3 +13,6 @@ Cloud/GCE/config.sh
# node.js dependencies, used by the JavaScript parser for the FuzzIL compiler
node_modules
package-lock.json

# results dir and workerd corpus
workerd*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you really need an in-place directory for temporary files, it should have a fixed name and should only be ignored on the top level, e.g.

Suggested change
workerd*
/workerd

This will otherwise match any subdirectory that starts with workerd.

throw CompilerError.invalidNodeError("`await` is currently only supported in async functions")
}
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to @saelo's suggestion about splitting this into multiple changes. Also please don't comment out code. If this should be removed (why would we want to remove it in this case?), then it should be removed, not commented out. (same in Code.swift)

@@ -0,0 +1,59 @@
// Copyright 2020 Google LLC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be 2025?


let workerdProfile = Profile(
processArgs: { randomize in
["fuzzilli","/home/mschwarzl/projects/workerd/samples/reprl/config-full.capnp","--experimental"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn't be user-specific code paths in here.

Comment on lines +44 to 46
} else {
print("REPRL context initialized successfully.")
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
} else {
print("REPRL context initialized successfully.")
}
}
print("REPRL context initialized successfully.")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants