Skip to content

fix: verify SHA256 checksum in npm postinstall script#650

Merged
jpoehnelt merged 1 commit into
mainfrom
fix/npm-sha256-verify
Mar 31, 2026
Merged

fix: verify SHA256 checksum in npm postinstall script#650
jpoehnelt merged 1 commit into
mainfrom
fix/npm-sha256-verify

Conversation

@jpoehnelt
Copy link
Copy Markdown
Contributor

The npm installer (install.js) downloads prebuilt binaries from GitHub Releases but never verified the .sha256 checksum files that the release workflow generates alongside each archive.

Changes:

  • Download the .sha256 sidecar file after fetching the archive
  • Compute SHA256 of the downloaded archive using Node.js crypto
  • Compare and abort installation with a clear error on mismatch

Why: Without integrity verification, a compromised CDN/DNS or tampered GitHub Release could serve a malicious binary to npm users.

Part of supply chain hardening effort.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 31, 2026

🦋 Changeset detected

Latest commit: ef015ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@googleworkspace/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a security hardening measure to the npm installation process. By verifying the integrity of downloaded binaries against their corresponding SHA256 checksums, the package ensures that the artifacts have not been compromised during transit or storage, significantly improving the supply chain security for users.

Highlights

  • Checksum Verification: Implemented SHA256 verification for downloaded binaries in the npm postinstall script to ensure integrity.
  • Security Enhancement: Added a mandatory check against the .sha256 sidecar file to prevent the installation of tampered or malicious binaries.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@googleworkspace-bot googleworkspace-bot added cla: yes This human has signed the Contributor License Agreement. and removed area: distribution labels Mar 31, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds SHA256 checksum verification for downloaded binaries in the npm post-install script to ensure file integrity. The review feedback identifies a potential memory exhaustion issue when reading large binaries into memory for hashing and recommends using a stream-based approach for more efficient and robust hash calculation.

Comment thread npm/install.js
@github-actions github-actions Bot added the gemini: reviewed Gemini Code Assist has reviewed the latest changes label Mar 31, 2026
@jpoehnelt jpoehnelt merged commit 158f93a into main Mar 31, 2026
37 checks passed
@jpoehnelt jpoehnelt deleted the fix/npm-sha256-verify branch March 31, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. gemini: reviewed Gemini Code Assist has reviewed the latest changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants