fix: verify SHA256 checksum in npm postinstall script#650
Conversation
🦋 Changeset detectedLatest commit: ef015ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a security hardening measure to the npm installation process. By verifying the integrity of downloaded binaries against their corresponding SHA256 checksums, the package ensures that the artifacts have not been compromised during transit or storage, significantly improving the supply chain security for users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds SHA256 checksum verification for downloaded binaries in the npm post-install script to ensure file integrity. The review feedback identifies a potential memory exhaustion issue when reading large binaries into memory for hashing and recommends using a stream-based approach for more efficient and robust hash calculation.
The npm installer (
install.js) downloads prebuilt binaries from GitHub Releases but never verified the.sha256checksum files that the release workflow generates alongside each archive.Changes:
.sha256sidecar file after fetching the archivecryptoWhy: Without integrity verification, a compromised CDN/DNS or tampered GitHub Release could serve a malicious binary to npm users.
Part of supply chain hardening effort.