ci: use pnpm install --frozen-lockfile in release workflow#652
ci: use pnpm install --frozen-lockfile in release workflow#652jpoehnelt wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 44a59c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the release workflow to enforce the use of the existing lockfile during dependency installation. By ensuring that the CI environment matches the local development environment exactly, this change improves the reliability and security of the release pipeline. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a changeset file documenting the intent to use pnpm install --frozen-lockfile in CI for reproducible dependency resolution. However, the actual implementation changes to the CI workflow files are missing from the PR, and it was noted that this behavior is already the default for pnpm v10 in CI environments.
| "@googleworkspace/cli": patch | ||
| --- | ||
|
|
||
| Use `pnpm install --frozen-lockfile` in CI for reproducible dependency resolution |
There was a problem hiding this comment.
The pull request is missing the actual implementation changes. While this changeset file describes the intent to use pnpm install --frozen-lockfile in CI, no modifications to the workflow configuration files (e.g., .github/workflows/release.yml) are included in the diff. Additionally, note that since the project uses pnpm v10, --frozen-lockfile is already the default behavior in CI environments, though explicitly adding it is still acceptable for clarity.
The release-changesets workflow ran
pnpm installwithout--frozen-lockfile, which could resolve different dependency versions than what was tested locally.Change: Add
--frozen-lockfileflag to ensure CI uses exactly the versions from the committed lockfile.Part of supply chain hardening effort.