Skip to content

ci: use pnpm install --frozen-lockfile in release workflow#652

Closed
jpoehnelt wants to merge 1 commit into
mainfrom
fix/frozen-lockfile-ci
Closed

ci: use pnpm install --frozen-lockfile in release workflow#652
jpoehnelt wants to merge 1 commit into
mainfrom
fix/frozen-lockfile-ci

Conversation

@jpoehnelt
Copy link
Copy Markdown
Contributor

The release-changesets workflow ran pnpm install without --frozen-lockfile, which could resolve different dependency versions than what was tested locally.

Change: Add --frozen-lockfile flag to ensure CI uses exactly the versions from the committed lockfile.

Part of supply chain hardening effort.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 31, 2026

🦋 Changeset detected

Latest commit: 44a59c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@googleworkspace/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the release workflow to enforce the use of the existing lockfile during dependency installation. By ensuring that the CI environment matches the local development environment exactly, this change improves the reliability and security of the release pipeline.

Highlights

  • CI Workflow Security: Added the --frozen-lockfile flag to the pnpm install command within the release workflow to ensure consistent dependency resolution.
  • Supply Chain Hardening: Implemented stricter dependency management to prevent unintended version updates during the release process.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/release-changesets.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@googleworkspace-bot googleworkspace-bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a changeset file documenting the intent to use pnpm install --frozen-lockfile in CI for reproducible dependency resolution. However, the actual implementation changes to the CI workflow files are missing from the PR, and it was noted that this behavior is already the default for pnpm v10 in CI environments.

"@googleworkspace/cli": patch
---

Use `pnpm install --frozen-lockfile` in CI for reproducible dependency resolution
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pull request is missing the actual implementation changes. While this changeset file describes the intent to use pnpm install --frozen-lockfile in CI, no modifications to the workflow configuration files (e.g., .github/workflows/release.yml) are included in the diff. Additionally, note that since the project uses pnpm v10, --frozen-lockfile is already the default behavior in CI environments, though explicitly adding it is still acceptable for clarity.

@github-actions github-actions Bot added the gemini: reviewed Gemini Code Assist has reviewed the latest changes label Mar 31, 2026
@jpoehnelt jpoehnelt closed this Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: distribution cla: yes This human has signed the Contributor License Agreement. gemini: reviewed Gemini Code Assist has reviewed the latest changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants