openstack/clientconfig: fix dropped errors #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierreprinetti
requested changes
Dec 6, 2023
| @@ -330,7 +330,7 @@ func GetCloudFromYAML(opts *ClientOpts) (*Cloud, error) { | |||
|
|
|||
| cloud.Interface = "" | |||
|
|
|||
| return cloud, nil | |||
| return cloud, err | |||
There was a problem hiding this comment.
Thanks for catching this. Can you please handle this error right where it's produced (line 312), possibly with an additional error message like we do on line 291?
| @@ -46,6 +46,9 @@ func mergeClouds(override, cloud interface{}) (*Cloud, error) { | |||
| var mergedCloud Cloud | |||
| mergedInterface := mergeInterfaces(overrideInterface, cloudInterface) | |||
| mergedJson, err := json.Marshal(mergedInterface) | |||
| if err != nil { | |||
|
If you still want to work on this, I think we should have some test coverage of the change you propose. |
pierreprinetti
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
OK let's merge what we have, which is worthwhile. Thanks for this @alrs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up two dropped
errvariables inopenstack/clientconfig.