Minor changes #241
Merged
Minor changes #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandre
previously approved these changes
Dec 20, 2024
The purpose of github.com/mitchellh/go-homedir was to expand the user home directory without CGO. Recent versions of `os/user` can retrieve the user home directory without CGO and thus enable cross-compilation. This change does not add the missing functionality of expanding non-current-user home directories in a path (e.g. `~user2/dir/subdir`). The reason for this is that the input of `pathOrContents` could be a blob and parsing every byte slice matching `^~.*\/.*` as a path considerably increases the chances that a binary blob is mistakenly parsed as a path.
pierreprinetti
force-pushed
the
minor
branch
from
3d15577 to
aecae7e
Compare
mandre
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes two changes.
First commit:
Second commit: