#228 Throw meaningful exception when GetNodeFromLink() is used with a…

… folder share or GetNodesFromLink() with a file share
gpailler · Mar 19, 2023 · 768516c · 768516c
1 parent 7fa231c
commit 768516c
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/MegaApiClient.Tests/NodeOperations.cs b/MegaApiClient.Tests/NodeOperations.cs
@@ -300,6 +300,22 @@ public void GetNodeFromLink_WithFileAttributes_Succeeds(string fileLink)
       Assert.Equal(2, node.FileAttributes.Length);
     }
 
+    [Theory]
+    [JsonInputsDataAttribute("FolderLink")]
+    public void GetNodeFromLink_WithFolderLink_Throws(string folderLink)
+    {
+      var exception = Assert.Throws<ArgumentException>(() => Context.Client.GetNodeFromLink(new Uri(folderLink)));
+      Assert.Equal("Uri must be a valid file share starting with /file/. Use GetNodesFromLink() for folder share (Parameter 'uri')", exception.Message);
+    }
+
+    [Theory]
+    [JsonInputsDataAttribute("FileLink")]
+    public void GetNodesFromLink_WithFileLink_Throws(string fileLink)
+    {
+      var exception = Assert.Throws<ArgumentException>(() => Context.Client.GetNodesFromLink(new Uri(fileLink)));
+      Assert.Equal("Uri must be a valid folder share starting with /folder/. Use GetNodeFromLink() for file share (Parameter 'uri')", exception.Message);
+    }
+
     [Theory]
     [JsonInputsDataAttribute("ZipFileLink")]
     public void GetNodeFromLink_WithoutFileAttributes_Succeeds(string fileLink)

diff --git a/MegaApiClient/MegaApiClient.cs b/MegaApiClient/MegaApiClient.cs
@@ -660,7 +660,12 @@ public INode GetNodeFromLink(Uri uri)
     {
       if (uri == null)
       {
-        throw new ArgumentNullException("uri");
+        throw new ArgumentNullException(nameof(uri));
+      }
+
+      if (uri.AbsolutePath.StartsWith("/file/") == false)
+      {
+        throw new ArgumentException("Uri must be a valid file share starting with /file/. Use GetNodesFromLink() for folder share", nameof(uri));
       }
 
       EnsureLoggedIn();
@@ -686,7 +691,12 @@ public IEnumerable<INode> GetNodesFromLink(Uri uri)
     {
       if (uri == null)
       {
-        throw new ArgumentNullException("uri");
+        throw new ArgumentNullException(nameof(uri));
+      }
+
+      if (uri.AbsolutePath.StartsWith("/folder/") == false)
+      {
+        throw new ArgumentException("Uri must be a valid folder share starting with /folder/. Use GetNodeFromLink() for file share", nameof(uri));
       }
 
       EnsureLoggedIn();