random-drbg: fix missing error check from _gcry_rngdrbg_cavs_test() #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return value of `_gcry_rngdrbg_cavs_test()` was immediately overwritten by `memcmp()` result, leading to potential loss of error information. This could cause the health check to succeed even if the internal CAVS test function failed. This issue was reported by a static analyzer: > Return value of function '_gcry_rngdrbg_cavs_test' passed to 'ret' > at random-drbg.c:2378 will be rewritten later. To fix this, we now check the return code of `_gcry_rngdrbg_cavs_test()` and only call `memcmp()` if the test execution succeeded. Signed-off-by: Anton Moryakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return value of
_gcry_rngdrbg_cavs_test()was immediately overwritten bymemcmp()result, leading to potential loss of error information. This could cause the health check to succeed even if the internal CAVS test function failed.This issue was reported by a static analyzer:
To fix this, we now check the return code of
_gcry_rngdrbg_cavs_test()and only callmemcmp()if the test execution succeeded.