Repository navigation
Windows compatibility - #294
Merged
Merged
Conversation
markwong167
commented
Apr 27, 2026
markwong167
commented
Collaborator
- Removed excess package.json
- added shared node_modules to dockerignore
- network_mode: host is incompatible with Windows, this fix should be Linux compatible
Collaborator
Author
|
It appears to be line 21 of .github/workflows/ci.yml where we need some PAT token.
Would it be better to use:
|
tdresser
approved these changes
Apr 27, 2026
tdresser
left a comment
tdresser
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, I'd check with Ian for the token question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.