Skip to content

feat: include fields in prompt only when there are fields #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2024
Merged

feat: include fields in prompt only when there are fields #698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkg/prompt/prompt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,13 @@ func SysPrompt(ctx context.Context, envs []string, input string, _ chan<- string

for _, env := range envs {
if url, ok := strings.CutPrefix(env, types.PromptURLEnvVar+"="); ok {
var fields []string
if params.Fields != "" {
fields = strings.Split(params.Fields, ",")
}
httpPrompt := types.Prompt{
Message: params.Message,
Fields: strings.Split(params.Fields, ","),
Fields: fields,
Sensitive: params.Sensitive == "true",
}
return sysPromptHTTP(ctx, envs, url, httpPrompt)
Expand All @@ -76,7 +80,7 @@ func SysPrompt(ctx context.Context, envs []string, input string, _ chan<- string
func sysPrompt(ctx context.Context, req types.Prompt) (_ string, err error) {
defer context2.GetPauseFuncFromCtx(ctx)()()

if req.Message != "" && len(req.Fields) == 1 && strings.TrimSpace(req.Fields[0]) == "" {
if req.Message != "" && len(req.Fields) == 0 {
var errs []error
_, err := fmt.Fprintln(os.Stderr, req.Message)
errs = append(errs, err)
Expand Down