feat: add standalone mode to SDKServer and server options #835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinor
force-pushed
the
sdkserver/standalone
branch
2 times, most recently
from
b309295 to
937997f
Compare
rinor
force-pushed
the
sdkserver/standalone
branch
2 times, most recently
from
f9d95e5 to
d4aced9
Compare
Added a new `Standalone` boolean field to the `SDKServer` and `Options` structs to support running the server in standalone mode. Updated the server run logic to conditionally skip the stdin read hack when in standalone mode.
rinor
force-pushed
the
sdkserver/standalone
branch
from
d4aced9 to
258e4db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new
Standaloneboolean field to theSDKServerandOptionsstructs to support running the server in standalone mode. Updated the server run logic to conditionally skip the stdin read hack when in standalone mode.Why: because I need to run a single instance of the server on my own, but the hack prevents the server to start in environments where stdin is 'closed' (reading returns EOF immediately), ie: